[jira] [Comment Edited] (SOLR-15646) Add a non secure RSAKeyPair keygen mode for tests.

["Mark Robert Miller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422509#comment-17422509 ] 

Mark Robert Miller edited comment on SOLR-15646 at 9/30/21, 3:24 AM:
---------------------------------------------------------------------

(Re universally implemented) That’s just aggravating what would still be every test and in parallel for each test jvm.

Robert is still advocating for having pre gen’d keys in the test resources folder.

I still didn’t like the idea of having to control this. If you are not dealing with it as a problem, it’s just impossible to be anything well maintained or carried forward. And while having less config is helpful in some ways, it also means less test coverage for config. There has to be a balance, but minimizing enough to really help here would be quite a hit on the config we test. System prop subs and what not on a couple configs can’t really cover the real world of what we really should have some testing on.

However, the damn key generation is still very expensive.  Something like json faceting test is ripping out keys and BigInteger algorithms are slow.

I would compromise to, shared keys in a resource folder for the 98% of tests that could care less about public key handlers existence, and the current shared keys system for the tests that do. 


was (Author: markrmiller):
That’s just aggravating what would still be every test and in parallel for each test jvm.

Robert is still advocating for have pre gen’d keys in the test resources folder.

I still didn’t like the idea of having to control this. And while having less confit is helpful in some ways, it also means less test coverage for config. There has to be a balance, but minimizing enough to really help here would be quite a hit on the confit we test. System prop subs and what not on a couple confits can’t really cover the real world of what we really should have some testing on.

However, the damn key generation is still very expensive.  Something like json faceting test is ripping out keys BigInteger algorithms are slow.

I would compromise to, shared keys in a resource folder for the 98% of tests that could care less about public key handlers existence, and the current shared keys for the tests that do. 

> Add a non secure RSAKeyPair keygen mode for tests.
> --------------------------------------------------
>
>                 Key: SOLR-15646
>                 URL: https://issues.apache.org/jira/browse/SOLR-15646
>             Project: Solr
>          Issue Type: Test
>          Components: Tests
>            Reporter: Mark Robert Miller
>            Assignee: Mark Robert Miller
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org