You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/03/01 23:07:53 UTC
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12645
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
IMPALA-8153: [DOCS] Admission Control page added to web ui
Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
---
M docs/topics/impala_webui.xml
1 file changed, 83 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12645/1
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@110
PS1, Line 110: <p>To disable web UI for an impalad, restart </p>
This is missing something? We need to change a flag to disable it.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 18:21:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12645
to look at the new patch set (#2).
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
IMPALA-8153: [DOCS] Admission Control page added to web ui
Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
---
M docs/topics/impala_webui.xml
1 file changed, 87 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12645/2
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/245/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 23:16:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/243/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 03:44:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/244/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 20:52:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/245/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 23:19:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@153
PS1, Line 153: <li>Exponential moving average of time in queue for the past 10
: queries</li>
is there intent here to highlight stats which are not a part of the regular pool metrics?
if yes them maybe also mention the "queuing reason of the query at the head of the queue"
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@157
PS1, Line 157: the minimum
: and maximum query <codeph>MEM_LIMIT</codeph> ranges
should we mention here that it is referring to a pool config
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@161
PS1, Line 161: in real time.
maybe not mention "real-time" since that can mean the the info might be refreshed automatically (even though i know you have mentioned that in the next sentence).
You can probably say something along the lines of, The admission debug page displays information about all resource pool (to which queries have been submitted at least once), you can however click on the pool name to only display information relevant to that pool.
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@168
PS1, Line 168: </conbody>
also mention that you can reset the stats that keep track of historical data like Total-*, Exponential moving average of time in queue for the past 10 queries and the histogram
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 22:29:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12645
to look at the new patch set (#3).
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
IMPALA-8153: [DOCS] Admission Control page added to web ui
Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
---
M docs/topics/impala_webui.xml
1 file changed, 84 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12645/3
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/241/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 23:08:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/243/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 03:24:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@110
PS1, Line 110: <p>To disable web UI for an impalad, restart </p>
> This is missing something? We need to change a flag to disable it.
This section is hidden. I have a separate JIRA ticket to address this.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 19:56:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 00:21:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12645
to look at the new patch set (#4).
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
IMPALA-8153: [DOCS] Admission Control page added to web ui
Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
---
M docs/topics/impala_webui.xml
1 file changed, 96 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/12645/4
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
IMPALA-8153: [DOCS] Admission Control page added to web ui
Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Reviewed-on: http://gerrit.cloudera.org:8080/12645
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
---
M docs/topics/impala_webui.xml
1 file changed, 96 insertions(+), 47 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Bikramjeet Vig: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@153
PS1, Line 153: <li>Exponential moving average of time in queue for the past 10
: queries</li>
> is there intent here to highlight stats which are not a part of the regular
This is mentioned to highlight the last 10 queries as the UI does not mention that.
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@157
PS1, Line 157: the minimum
: and maximum query <codeph>MEM_LIMIT</codeph> ranges
> should we mention here that it is referring to a pool config
Done
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@161
PS1, Line 161: in real time.
> maybe not mention "real-time" since that can mean the the info might be ref
Done
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@168
PS1, Line 168: </conbody>
> also mention that you can reset the stats that keep track of historical dat
Done
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 03:23:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@153
PS1, Line 153: <li>Exponential moving average of time in queue for the past 10
: queries</li>
> This is mentioned to highlight the last 10 queries as the UI does not menti
actually the exponential moving average is of all the queries that it has seen. The reason the value will be 'close' to the average of the last 10 queries is because of the use of an exponential factor of 0.2
http://gerrit.cloudera.org:8080/#/c/12645/2/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/2/docs/topics/impala_webui.xml@162
PS2, Line 162: pool. You can refresh the debug page to see only the information for
nit: you can then refresh
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 18:03:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/1/docs/topics/impala_webui.xml@153
PS1, Line 153: <li>Exponential moving average of time in queue for the past 10
: queries</li>
> actually the exponential moving average is of all the queries that it has s
Removed
http://gerrit.cloudera.org:8080/#/c/12645/2/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/12645/2/docs/topics/impala_webui.xml@162
PS2, Line 162: pool. You can refresh the debug page to see only the information for
> nit: you can then refresh
Done
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 20:52:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/244/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 20:55:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/241/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 23:27:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8153: [DOCS] Admission Control page added to web ui
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12645 )
Change subject: IMPALA-8153: [DOCS] Admission Control page added to web ui
......................................................................
Patch Set 1: Code-Review+1
Will let bikram +2 this since it's his code change.
--
To view, visit http://gerrit.cloudera.org:8080/12645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa4a23d5dc3be678080c565a311d0ee9660a6b19
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 20:01:06 +0000
Gerrit-HasComments: No