[jira] [Commented] (CALCITE-1683) Implement ProjectFilterTranspose, FilterProjectTranspose, AggregateFilterTranspose, FilterAggregateTranspose rules for Druid

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923547#comment-15923547 ] 

Julian Hyde commented on CALCITE-1683:
--------------------------------------

There are checkstyle errors. Can you fix them please. Also, even though checkstyle doesn't check this, can you indent function arguments 4. Not align with the open parenthesis.

When you add a constructor for a rule, make sure that {{RelBuilderFactory relBuilderFactory}} is one of the arguments. Pass in {{RelFactories.LOGICAL_BUILDER}} if your particular rule instance wants the default factory.

Make sure that only one of the constructors calls {{super(...)}}; all other constructors should call {{this(...)}}. Therefore there's only one place that you need to place a breakpoint. (Scala enforces this, and sadly Java/checkstyle do not, but it is part of our house style.)

> Implement ProjectFilterTranspose, FilterProjectTranspose, AggregateFilterTranspose, FilterAggregateTranspose rules for Druid
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1683
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1683
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Nishant Bangarwa
>            Assignee: Nishant Bangarwa
>
> came as part of discussion for https://issues.apache.org/jira/browse/HIVE-15619
> Druid specific rules will match DruidQuery at the leaf node, e.g., for ProjectFilterTransposeRule Project-Filter-DruidQuery



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)