[jira] Commented: (COCOON-1685) Additional ProcessingPhase.READ_FROM_REQUEST_VALUE event sent

["Sylvain Wallez (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/COCOON-1685?page=comments#action_12366913 ] 

Sylvain Wallez commented on COCOON-1685:
----------------------------------------

I think the 3rd solution makes most sense, as it allows listeners to be triggered both before and after the request has been added.

And if some actions have to be taken at form creation time, there's the <on-create> listener, which is called before binding

> Additional ProcessingPhase.READ_FROM_REQUEST_VALUE event sent
> -------------------------------------------------------------
>
>          Key: COCOON-1685
>          URL: http://issues.apache.org/jira/browse/COCOON-1685
>      Project: Cocoon
>         Type: Bug
>   Components: Blocks: Forms
>     Versions: 2.1.8
>     Reporter: Simone Gianni

>
> In the Form.process() method, there is a listener.phaseEnded on line 296 which sends a LOAD_MODEL_VALUE the first time the form is executed, and a READ_FROM_REQUEST_VALUE all the other times. If a ProcessingPhaseListener is registered it will receive a READ_FROM_REQUEST_VALUE before the request has been processed, and another one after.
> IMMO there are the following possible solutions :
> - remove this event broadcast.
> - send this event only if phase is LOAD_MODEL_VALUE, so that this event takes his chance to get broadcasted, while the spurious one doesn't.
> - add a "PROCESS_INITIALIZED" phase event and send this one at this point.
> I can produce the patch if needed, but don't know which solution is the best one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira