[jira] [Commented] (PDFBOX-1973) Don't wrap Exceptions with COSVisitorException

["John Hewson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930036#comment-13930036 ] 

John Hewson commented on PDFBOX-1973:
-------------------------------------

Ok, revision 1576203 replaces all instances of COSVisitorException with the actual exceptions which it wrapped, namely IOException, CryptographyException, SignatureException, NoSuchAlgorithmException.

We can see now that there are too many similar (yet different) exceptions being thrown, so it looks like some work is needed to reduce these.

> Don't wrap Exceptions with COSVisitorException
> ----------------------------------------------
>
>                 Key: PDFBOX-1973
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1973
>             Project: PDFBox
>          Issue Type: Improvement
>            Reporter: John Hewson
>            Assignee: John Hewson
>            Priority: Minor
>
> COSVisitorException is redundant, it is a simple wrapper for SignatureException, CryptographyException and NoSuchAlgorithmException and should be replaced by those exceptions directly.
> For example, we can replace:
> public void write(PDDocument doc) throws COSVisitorException
> With:
> public void write(PDDocument doc) throws IOException, CryptographyException
> and so on...



--
This message was sent by Atlassian JIRA
(v6.2#6252)