You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Chip Childers <ch...@apache.org> on 2013/06/26 20:16:44 UTC

Re: Review Request 12105: Remove Hypervisor.HypervisorType.Hyperv special cases from manager code that are unused or unsupported.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12105/
-----------------------------------------------------------

(Updated June 26, 2013, 6:16 p.m.)


Review request for cloudstack, Alex Huang, Chip Childers, and edison su.


Changes
-------

Adding the cloudstack group.


Repository: cloudstack-git


Description
-------

Remove Hypervisor.HypervisorType.Hyperv special cases from manager code that are unused or unsupported.
Specifically, there is no CIFS secondary storage class "CifsSecondaryStorageResource".  Also, the Hyper-V plugin's ServerResource is contacted by the management server and not the other way around.


Diffs
-----

  agent/src/com/cloud/agent/VmmAgentShell.java 190d1168284243f9e860677a03311da9db31c745 
  api/src/com/cloud/storage/Storage.java 16ef0192e325af174f2b2d21137f629ddffad6ce 
  client/tomcatconf/applicationContext.xml.in ac1f3e46fdb43b4a5e38f9f2b3c498a2c258a0aa 
  core/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java 725f0cc1ae214447f20f5cd51c40e7e9128f0506 
  engine/storage/integration-test/test/resource/component.xml 5ba87e8ebe9a682b320c60caf0e0057d2eb92027 
  plugins/network-elements/dns-notifier/resources/components-example.xml 717c5e063fe0271eeb1143215a493c6342c5811e 
  server/src/com/cloud/hypervisor/guru/HypervGuru.java 630080e21cbb6a501d67bda41179feb278b3d79c 
  server/src/com/cloud/hypervisor/hyperv/HypervServerDiscoverer.java 06658b7f3e2ea5e80edf012dcaf29d980758084d 
  server/src/com/cloud/resource/ResourceManagerImpl.java fe91cb337d0f5901012ca45e131d9cb2f7c54cf2 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 954c7e970f02e7ba0eae6e8e1616d9a08c9168b0 

Diff: https://reviews.apache.org/r/12105/diff/


Testing
-------

Compiles properly with mvn clean install


Thanks,

Donal Lafferty