You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/04/10 12:07:47 UTC
Review Request 66526: Renamed resource provider `AgentRegistrar` to
`GenericRegistrar`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735
Repository: mesos
Description
-------
This registrar and its matching process can work on generic storage
and is currently used to work on an agent's persist store.
Its name should not be tied the agent, so we rename the registrar in
this patch.
Diffs
-----
src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
src/resource_provider/registrar.cpp 9eb49f1327a0b598c5464a29a09ee286d7018f09
Diff: https://reviews.apache.org/r/66526/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 66526: Renamed resource provider `AgentRegistrar`
to `GenericRegistrar`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/#review201470
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On April 10, 2018, 12:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66526/
> -----------------------------------------------------------
>
> (Updated April 10, 2018, 12:07 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
>
>
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This registrar and its matching process can work on generic storage
> and is currently used to work on an agent's persist store.
>
> Its name should not be tied the agent, so we rename the registrar in
> this patch.
>
>
> Diffs
> -----
>
> src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
> src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b
>
>
> Diff: https://reviews.apache.org/r/66526/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 66526: Renamed resource provider `AgentRegistrar`
to `GenericRegistrar`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/
-----------------------------------------------------------
(Updated April 25, 2018, 12:56 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
Changes
-------
Renamed test.
Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735
Repository: mesos
Description (updated)
-------
This registrar and its matching process can work on generic storage
and it is currently used to work on an agent's persist store.
Its name should not be tied to the agent, so we rename the registrar
in this patch.
Diffs (updated)
-----
src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b
src/tests/resource_provider_manager_tests.cpp c52541bf130ccf4795b989b53331176a64a097ea
Diff: https://reviews.apache.org/r/66526/diff/4/
Changes: https://reviews.apache.org/r/66526/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 66526: Renamed resource provider `AgentRegistrar`
to `GenericRegistrar`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/#review201604
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On April 19, 2018, 12:29 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66526/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 12:29 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
>
>
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This registrar and its matching process can work on generic storage
> and is currently used to work on an agent's persist store.
>
> Its name should not be tied the agent, so we rename the registrar in
> this patch.
>
>
> Diffs
> -----
>
> src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
> src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b
>
>
> Diff: https://reviews.apache.org/r/66526/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 66526: Renamed resource provider `AgentRegistrar`
to `GenericRegistrar`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/
-----------------------------------------------------------
(Updated April 19, 2018, 2:29 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
Changes
-------
Addressed issue raised by Chun.
Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735
Repository: mesos
Description
-------
This registrar and its matching process can work on generic storage
and is currently used to work on an agent's persist store.
Its name should not be tied the agent, so we rename the registrar in
this patch.
Diffs (updated)
-----
src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b
Diff: https://reviews.apache.org/r/66526/diff/3/
Changes: https://reviews.apache.org/r/66526/diff/2-3/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 66526: Renamed resource provider `AgentRegistrar`
to `GenericRegistrar`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66526/#review201498
-----------------------------------------------------------
src/resource_provider/registrar.cpp
Line 186 (original), 186 (patched)
<https://reviews.apache.org/r/66526/#comment282752>
`"resource-provider-generic-registrar"`
- Chun-Hung Hsiao
On April 10, 2018, 12:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66526/
> -----------------------------------------------------------
>
> (Updated April 10, 2018, 12:07 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
>
>
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This registrar and its matching process can work on generic storage
> and is currently used to work on an agent's persist store.
>
> Its name should not be tied the agent, so we rename the registrar in
> this patch.
>
>
> Diffs
> -----
>
> src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45
> src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b
>
>
> Diff: https://reviews.apache.org/r/66526/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>