You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2008/09/11 13:22:37 UTC
Re: svn commit: r694183 - in /ofbiz/trunk/applications: ecommerce/config/EcommerceUiLabels.xml ecommerce/data/DemoProduct.xml securityext/email/default/passwordemail.ftl
Hi Ashish,
Why a CommonNewSmall in Ecommerce when there is already a CommonNew in Common, to keep it smaller in other languages ?
And should not CommonYourCapital better names EcommerceYourCapital ?
Thanks
Jacques
> Author: ashish
> Date: Thu Sep 11 01:51:39 2008
> New Revision: 694183
>
> URL: http://svn.apache.org/viewvc?rev=694183&view=rev
> Log:
> Some UI label change in passwordemail template.
> Changed ${userLoginId} to ${userLogin.userLoginId}.
>
> Modified:
> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>
> Modified: ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml?rev=694183&r1=694182&r2=694183&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml (original)
> +++ ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml Thu Sep 11 01:51:39 2008
> @@ -977,6 +977,9 @@
> <value xml:lang="ru">болÑÑе Ñем</value>
> <value xml:lang="th">มาà¸à¸à¸§à¹à¸²</value>
> </property>
> + <property key="CommonNewSmall">
> + <value xml:lang="en">new</value>
> + </property>
> <property key="CommonNewListSubscription">
> <value xml:lang="en">New List Subscription</value>
> <value xml:lang="es">Nueva lista de subscripción</value>
> @@ -1029,6 +1032,9 @@
> <value xml:lang="it">tuo</value>
> <value xml:lang="th">à¸à¸à¸à¸à¸¸à¸</value>
> </property>
> + <property key="CommonYourCapital">
> + <value xml:lang="en">Your</value>
> + </property>
> <property key="EcommerceAccountLogin">
> <value xml:lang="en">Your account login is:</value>
> <value xml:lang="es">Usuario</value>
>
> Modified: ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml?rev=694183&r1=694182&r2=694183&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml (original)
> +++ ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml Thu Sep 11 01:51:39 2008
> @@ -86,7 +86,7 @@
>
> <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_TELL_FRIEND"
> bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend" subject="${sendFrom} has sent you a link!"
> fromAddress="ofbiztest@yahoo.com"/>
>
> - <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_PWD_RETRIEVE"
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail" subject="OFBiz Demo - Password Reminder
> (${userLoginId})" fromAddress="ofbiztest@yahoo.com"/>
> + <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_PWD_RETRIEVE"
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail" subject="OFBiz Demo - Password Reminder
> (${userLogin.userLoginId})" fromAddress="ofbiztest@yahoo.com"/>
>
> <ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_QUO_CONFIRM"
> bodyScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple"
> xslfoAttachScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#QuoteReport" subject="OFBiz Demo - Quote
> Confirmation #${quoteId}" bccAddress="ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>
>
>
> Modified: ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl?rev=694183&r1=694182&r2=694183&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl (original)
> +++ ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl Thu Sep 11 01:51:39 2008
> @@ -23,6 +23,6 @@
> <body>
> <div>${uiLabelMap.EcommerceThisEmailIsInResponseToYourRequestToHave} <#if
> useEncryption>${uiLabelMap.EcommerceANew}<#else>${uiLabelMap.CommonYour}</#if> ${uiLabelMap.EcommercePasswordSentToYou}.</div>
> <br/>
> - <div>${uiLabelMap.CommonYour} <#if useEncryption>${uiLabelMap.CommonNew}</#if> ${uiLabelMap.EcommercePasswordIs}
> "${password}"</div>
> + <div>${uiLabelMap.CommonYourCapital} <#if useEncryption>${uiLabelMap.CommonNewSmall}</#if> ${uiLabelMap.EcommercePasswordIs}
> "${password}"</div>
> </body>
> </html>
>
>
Re: svn commit: r694183 - in /ofbiz/trunk/applications: ecommerce/config/EcommerceUiLabels.xml ecommerce/data/DemoProduct.xml securityext/email/default/passwordemail.ftl
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks for the explanation Ashish,
I agree with Bruno. We should try, as much as possible, to use sentences, not words.
Jacques
From: "Ashish Vijaywargiya" <vi...@gmail.com>
Thanks for your comment Jacques.
Before my commit the contents of passwordemail template was :-
----------------------------------
This email is in response to your request to have a new password sent to
you.
your CommonNew password is "auto54630"
----------------------------------
In the above content the first line looks good.
But if you will see the second line then it starts with the small letter
word i.e "your".
If you include the property file CommonUiLabels.xml in the Screen definition
of passwordemail template then the second line will become :-
----------------------------------
your New password is "auto54630"
----------------------------------
So I searched for the "Your" & "new" unique word in *UiLabels.xml file for
making the second sentence appropriate but didn't find anyone.
Rest comment Inline:-
--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore
On Thu, Sep 11, 2008 at 4:52 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi Ashish,
>
> Why a CommonNewSmall in Ecommerce when there is already a CommonNew in
> Common, to keep it smaller in other languages ?
CommonNew from CommonUiLabels.xml gives the "New" and I was looking for
"new".
>
> And should not CommonYourCapital better names EcommerceYourCapital ?
Few UiLabels by prefix Common* already exists in Ecommerce so I have
followed that pattern.
For distinguishing "CommonYour" from new one I kept "Capital" suffix in new
UiLabel.
I am fine in having any of the new label name but the name given by me
looked more appropriate to me.
Please let me know if you still have some question.
>
>
> Thanks
>
> Jacques
>
>
> Author: ashish
>> Date: Thu Sep 11 01:51:39 2008
>> New Revision: 694183
>>
>> URL: http://svn.apache.org/viewvc?rev=694183&view=rev
>> Log:
>> Some UI label change in passwordemail template.
>> Changed ${userLoginId} to ${userLogin.userLoginId}.
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
>> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>>
>> Modified: ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> (original)
>> +++ ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml Thu
>> Sep 11 01:51:39 2008
>> @@ -977,6 +977,9 @@
>> <value xml:lang="ru">больше чем</value>
>> <value xml:lang="th">มาภภว่า</value>
>> </property>
>> + <property key="CommonNewSmall">
>> + <value xml:lang="en">new</value>
>> + </property>
>> <property key="CommonNewListSubscription">
>> <value xml:lang="en">New List Subscription</value>
>> <value xml:lang="es">Nueva lista de subscripción</value>
>> @@ -1029,6 +1032,9 @@
>> <value xml:lang="it">tuo</value>
>> <value xml:lang="th">ขà¸à¸‡à¸„ุà¸"</value>
>> </property>
>> + <property key="CommonYourCapital">
>> + <value xml:lang="en">Your</value>
>> + </property>
>> <property key="EcommerceAccountLogin">
>> <value xml:lang="en">Your account login is:</value>
>> <value xml:lang="es">Usuario</value>
>>
>> Modified: ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml (original)
>> +++ ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml Thu Sep 11
>> 01:51:39 2008
>> @@ -86,7 +86,7 @@
>>
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_TELL_FRIEND"
>> bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend"
>> subject="${sendFrom} has sent you a link!" fromAddress="
>> ofbiztest@yahoo.com"/>
>>
>> - <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_PWD_RETRIEVE"
>> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
>> subject="OFBiz Demo - Password Reminder (${userLoginId})" fromAddress="
>> ofbiztest@yahoo.com"/>
>> + <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_PWD_RETRIEVE"
>> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
>> subject="OFBiz Demo - Password Reminder (${userLogin.userLoginId})"
>> fromAddress="ofbiztest@yahoo.com"/>
>>
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_QUO_CONFIRM"
>> bodyScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple"
>> xslfoAttachScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#QuoteReport"
>> subject="OFBiz Demo - Quote Confirmation #${quoteId}" bccAddress="
>> ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>
>>
>>
>> Modified:
>> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> (original)
>> +++ ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> Thu Sep 11 01:51:39 2008
>> @@ -23,6 +23,6 @@
>> <body>
>> <div>${uiLabelMap.EcommerceThisEmailIsInResponseToYourRequestToHave} <#if
>> useEncryption>${uiLabelMap.EcommerceANew}<#else>${uiLabelMap.CommonYour}</#if>
>> ${uiLabelMap.EcommercePasswordSentToYou}.</div>
>> <br/>
>> - <div>${uiLabelMap.CommonYour} <#if
>> useEncryption>${uiLabelMap.CommonNew}</#if>
>> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
>> + <div>${uiLabelMap.CommonYourCapital} <#if
>> useEncryption>${uiLabelMap.CommonNewSmall}</#if>
>> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
>> </body>
>> </html>
>>
>>
>>
>
Re: svn commit: r694183 - in /ofbiz/trunk/applications: ecommerce/config/EcommerceUiLabels.xml ecommerce/data/DemoProduct.xml securityext/email/default/passwordemail.ftl
Posted by Ashish Vijaywargiya <vi...@gmail.com>.
Thanks Bruno for your Tip.
Done in rev # 694264.
Thanks Jacques for heads up :-)
--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore
On Thu, Sep 11, 2008 at 7:12 PM, Bruno Busco <br...@gmail.com> wrote:
> As a general rule we should try to have whole sentences as labels and not
> single words because the word order can be different in different
> languages.
> This will help also to solve the problem you are facing.
> The label could be "Your new password is:".
> My two cents.
> -Bruno
>
> 2008/9/11 Ashish Vijaywargiya <vi...@gmail.com>
>
> > Thanks for your comment Jacques.
> >
> > Before my commit the contents of passwordemail template was :-
> >
> > ----------------------------------
> > This email is in response to your request to have a new password sent to
> > you.
> >
> > your CommonNew password is "auto54630"
> > ----------------------------------
> >
> > In the above content the first line looks good.
> > But if you will see the second line then it starts with the small letter
> > word i.e "your".
> >
> > If you include the property file CommonUiLabels.xml in the Screen
> > definition
> > of passwordemail template then the second line will become :-
> >
> > ----------------------------------
> > your New password is "auto54630"
> > ----------------------------------
> >
> > So I searched for the "Your" & "new" unique word in *UiLabels.xml file
> for
> > making the second sentence appropriate but didn't find anyone.
> > Rest comment Inline:-
> >
> > --
> > Ashish Vijaywargiya
> > Indore (M.P), India
> > http://en.wikipedia.org/wiki/Indore
> >
> >
> > On Thu, Sep 11, 2008 at 4:52 PM, Jacques Le Roux <
> > jacques.le.roux@les7arts.com> wrote:
> >
> > > Hi Ashish,
> > >
> > > Why a CommonNewSmall in Ecommerce when there is already a CommonNew in
> > > Common, to keep it smaller in other languages ?
> >
> >
> > CommonNew from CommonUiLabels.xml gives the "New" and I was looking for
> > "new".
> >
> >
> > >
> > > And should not CommonYourCapital better names EcommerceYourCapital ?
> >
> >
> > Few UiLabels by prefix Common* already exists in Ecommerce so I have
> > followed that pattern.
> > For distinguishing "CommonYour" from new one I kept "Capital" suffix in
> new
> > UiLabel.
> >
> > I am fine in having any of the new label name but the name given by me
> > looked more appropriate to me.
> > Please let me know if you still have some question.
> >
> >
> > >
> > >
> > > Thanks
> > >
> > > Jacques
> > >
> > >
> > > Author: ashish
> > >> Date: Thu Sep 11 01:51:39 2008
> > >> New Revision: 694183
> > >>
> > >> URL: http://svn.apache.org/viewvc?rev=694183&view=rev
> > >> Log:
> > >> Some UI label change in passwordemail template.
> > >> Changed ${userLoginId} to ${userLogin.userLoginId}.
> > >>
> > >> Modified:
> > >> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> > >> ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> > >> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> > >>
> > >> Modified:
> > ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml?rev=694183&r1=694182&r2=694183&view=diff
> > >>
> > >>
> >
> ==============================================================================
> > >> --- ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> > >> (original)
> > >> +++ ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> Thu
> > >> Sep 11 01:51:39 2008
> > >> @@ -977,6 +977,9 @@
> > >> <value xml:lang="ru">больше чем</value>
> > >> <value xml:lang="th">มาภภว่า</value>
> > >> </property>
> > >> + <property key="CommonNewSmall">
> > >> + <value xml:lang="en">new</value>
> > >> + </property>
> > >> <property key="CommonNewListSubscription">
> > >> <value xml:lang="en">New List Subscription</value>
> > >> <value xml:lang="es">Nueva lista de subscripción</value>
> > >> @@ -1029,6 +1032,9 @@
> > >> <value xml:lang="it">tuo</value>
> > >> <value xml:lang="th">ขà¸à¸‡à¸„ุà¸"</value>
> > >> </property>
> > >> + <property key="CommonYourCapital">
> > >> + <value xml:lang="en">Your</value>
> > >> + </property>
> > >> <property key="EcommerceAccountLogin">
> > >> <value xml:lang="en">Your account login is:</value>
> > >> <value xml:lang="es">Usuario</value>
> > >>
> > >> Modified: ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml?rev=694183&r1=694182&r2=694183&view=diff
> > >>
> > >>
> >
> ==============================================================================
> > >> --- ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml (original)
> > >> +++ ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml Thu Sep 11
> > >> 01:51:39 2008
> > >> @@ -86,7 +86,7 @@
> > >>
> > >> <ProductStoreEmailSetting productStoreId="9000"
> > >> emailType="PRDS_TELL_FRIEND"
> > >>
> >
> bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend"
> > >> subject="${sendFrom} has sent you a link!" fromAddress="
> > >> ofbiztest@yahoo.com"/>
> > >>
> > >> - <ProductStoreEmailSetting productStoreId="9000"
> > >> emailType="PRDS_PWD_RETRIEVE"
> > >>
> >
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
> > >> subject="OFBiz Demo - Password Reminder (${userLoginId})"
> fromAddress="
> > >> ofbiztest@yahoo.com"/>
> > >> + <ProductStoreEmailSetting productStoreId="9000"
> > >> emailType="PRDS_PWD_RETRIEVE"
> > >>
> >
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
> > >> subject="OFBiz Demo - Password Reminder (${userLogin.userLoginId})"
> > >> fromAddress="ofbiztest@yahoo.com"/>
> > >>
> > >> <ProductStoreEmailSetting productStoreId="9000"
> > >> emailType="PRDS_QUO_CONFIRM"
> > >>
> >
> bodyScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple"
> > >>
> >
> xslfoAttachScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#QuoteReport"
> > >> subject="OFBiz Demo - Quote Confirmation #${quoteId}" bccAddress="
> > >> ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>
> > >>
> > >>
> > >> Modified:
> > >> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl?rev=694183&r1=694182&r2=694183&view=diff
> > >>
> > >>
> >
> ==============================================================================
> > >> ---
> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> > >> (original)
> > >> +++
> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> > >> Thu Sep 11 01:51:39 2008
> > >> @@ -23,6 +23,6 @@
> > >> <body>
> > >> <div>${uiLabelMap.EcommerceThisEmailIsInResponseToYourRequestToHave}
> > <#if
> > >>
> >
> useEncryption>${uiLabelMap.EcommerceANew}<#else>${uiLabelMap.CommonYour}</#if>
> > >> ${uiLabelMap.EcommercePasswordSentToYou}.</div>
> > >> <br/>
> > >> - <div>${uiLabelMap.CommonYour} <#if
> > >> useEncryption>${uiLabelMap.CommonNew}</#if>
> > >> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
> > >> + <div>${uiLabelMap.CommonYourCapital} <#if
> > >> useEncryption>${uiLabelMap.CommonNewSmall}</#if>
> > >> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
> > >> </body>
> > >> </html>
> > >>
> > >>
> > >>
> > >
> >
>
Re: svn commit: r694183 - in /ofbiz/trunk/applications: ecommerce/config/EcommerceUiLabels.xml ecommerce/data/DemoProduct.xml securityext/email/default/passwordemail.ftl
Posted by Bruno Busco <br...@gmail.com>.
As a general rule we should try to have whole sentences as labels and not
single words because the word order can be different in different languages.
This will help also to solve the problem you are facing.
The label could be "Your new password is:".
My two cents.
-Bruno
2008/9/11 Ashish Vijaywargiya <vi...@gmail.com>
> Thanks for your comment Jacques.
>
> Before my commit the contents of passwordemail template was :-
>
> ----------------------------------
> This email is in response to your request to have a new password sent to
> you.
>
> your CommonNew password is "auto54630"
> ----------------------------------
>
> In the above content the first line looks good.
> But if you will see the second line then it starts with the small letter
> word i.e "your".
>
> If you include the property file CommonUiLabels.xml in the Screen
> definition
> of passwordemail template then the second line will become :-
>
> ----------------------------------
> your New password is "auto54630"
> ----------------------------------
>
> So I searched for the "Your" & "new" unique word in *UiLabels.xml file for
> making the second sentence appropriate but didn't find anyone.
> Rest comment Inline:-
>
> --
> Ashish Vijaywargiya
> Indore (M.P), India
> http://en.wikipedia.org/wiki/Indore
>
>
> On Thu, Sep 11, 2008 at 4:52 PM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
> > Hi Ashish,
> >
> > Why a CommonNewSmall in Ecommerce when there is already a CommonNew in
> > Common, to keep it smaller in other languages ?
>
>
> CommonNew from CommonUiLabels.xml gives the "New" and I was looking for
> "new".
>
>
> >
> > And should not CommonYourCapital better names EcommerceYourCapital ?
>
>
> Few UiLabels by prefix Common* already exists in Ecommerce so I have
> followed that pattern.
> For distinguishing "CommonYour" from new one I kept "Capital" suffix in new
> UiLabel.
>
> I am fine in having any of the new label name but the name given by me
> looked more appropriate to me.
> Please let me know if you still have some question.
>
>
> >
> >
> > Thanks
> >
> > Jacques
> >
> >
> > Author: ashish
> >> Date: Thu Sep 11 01:51:39 2008
> >> New Revision: 694183
> >>
> >> URL: http://svn.apache.org/viewvc?rev=694183&view=rev
> >> Log:
> >> Some UI label change in passwordemail template.
> >> Changed ${userLoginId} to ${userLogin.userLoginId}.
> >>
> >> Modified:
> >> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> >> ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> >> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> >>
> >> Modified:
> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml?rev=694183&r1=694182&r2=694183&view=diff
> >>
> >>
> ==============================================================================
> >> --- ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
> >> (original)
> >> +++ ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml Thu
> >> Sep 11 01:51:39 2008
> >> @@ -977,6 +977,9 @@
> >> <value xml:lang="ru">больше чем</value>
> >> <value xml:lang="th">มาภภว่า</value>
> >> </property>
> >> + <property key="CommonNewSmall">
> >> + <value xml:lang="en">new</value>
> >> + </property>
> >> <property key="CommonNewListSubscription">
> >> <value xml:lang="en">New List Subscription</value>
> >> <value xml:lang="es">Nueva lista de subscripción</value>
> >> @@ -1029,6 +1032,9 @@
> >> <value xml:lang="it">tuo</value>
> >> <value xml:lang="th">ขà¸à¸‡à¸„ุà¸"</value>
> >> </property>
> >> + <property key="CommonYourCapital">
> >> + <value xml:lang="en">Your</value>
> >> + </property>
> >> <property key="EcommerceAccountLogin">
> >> <value xml:lang="en">Your account login is:</value>
> >> <value xml:lang="es">Usuario</value>
> >>
> >> Modified: ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml?rev=694183&r1=694182&r2=694183&view=diff
> >>
> >>
> ==============================================================================
> >> --- ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml (original)
> >> +++ ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml Thu Sep 11
> >> 01:51:39 2008
> >> @@ -86,7 +86,7 @@
> >>
> >> <ProductStoreEmailSetting productStoreId="9000"
> >> emailType="PRDS_TELL_FRIEND"
> >>
> bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend"
> >> subject="${sendFrom} has sent you a link!" fromAddress="
> >> ofbiztest@yahoo.com"/>
> >>
> >> - <ProductStoreEmailSetting productStoreId="9000"
> >> emailType="PRDS_PWD_RETRIEVE"
> >>
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
> >> subject="OFBiz Demo - Password Reminder (${userLoginId})" fromAddress="
> >> ofbiztest@yahoo.com"/>
> >> + <ProductStoreEmailSetting productStoreId="9000"
> >> emailType="PRDS_PWD_RETRIEVE"
> >>
> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
> >> subject="OFBiz Demo - Password Reminder (${userLogin.userLoginId})"
> >> fromAddress="ofbiztest@yahoo.com"/>
> >>
> >> <ProductStoreEmailSetting productStoreId="9000"
> >> emailType="PRDS_QUO_CONFIRM"
> >>
> bodyScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple"
> >>
> xslfoAttachScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#QuoteReport"
> >> subject="OFBiz Demo - Quote Confirmation #${quoteId}" bccAddress="
> >> ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>
> >>
> >>
> >> Modified:
> >> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl?rev=694183&r1=694182&r2=694183&view=diff
> >>
> >>
> ==============================================================================
> >> --- ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> >> (original)
> >> +++ ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
> >> Thu Sep 11 01:51:39 2008
> >> @@ -23,6 +23,6 @@
> >> <body>
> >> <div>${uiLabelMap.EcommerceThisEmailIsInResponseToYourRequestToHave}
> <#if
> >>
> useEncryption>${uiLabelMap.EcommerceANew}<#else>${uiLabelMap.CommonYour}</#if>
> >> ${uiLabelMap.EcommercePasswordSentToYou}.</div>
> >> <br/>
> >> - <div>${uiLabelMap.CommonYour} <#if
> >> useEncryption>${uiLabelMap.CommonNew}</#if>
> >> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
> >> + <div>${uiLabelMap.CommonYourCapital} <#if
> >> useEncryption>${uiLabelMap.CommonNewSmall}</#if>
> >> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
> >> </body>
> >> </html>
> >>
> >>
> >>
> >
>
Re: svn commit: r694183 - in /ofbiz/trunk/applications: ecommerce/config/EcommerceUiLabels.xml ecommerce/data/DemoProduct.xml securityext/email/default/passwordemail.ftl
Posted by Ashish Vijaywargiya <vi...@gmail.com>.
Thanks for your comment Jacques.
Before my commit the contents of passwordemail template was :-
----------------------------------
This email is in response to your request to have a new password sent to
you.
your CommonNew password is "auto54630"
----------------------------------
In the above content the first line looks good.
But if you will see the second line then it starts with the small letter
word i.e "your".
If you include the property file CommonUiLabels.xml in the Screen definition
of passwordemail template then the second line will become :-
----------------------------------
your New password is "auto54630"
----------------------------------
So I searched for the "Your" & "new" unique word in *UiLabels.xml file for
making the second sentence appropriate but didn't find anyone.
Rest comment Inline:-
--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore
On Thu, Sep 11, 2008 at 4:52 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Hi Ashish,
>
> Why a CommonNewSmall in Ecommerce when there is already a CommonNew in
> Common, to keep it smaller in other languages ?
CommonNew from CommonUiLabels.xml gives the "New" and I was looking for
"new".
>
> And should not CommonYourCapital better names EcommerceYourCapital ?
Few UiLabels by prefix Common* already exists in Ecommerce so I have
followed that pattern.
For distinguishing "CommonYour" from new one I kept "Capital" suffix in new
UiLabel.
I am fine in having any of the new label name but the name given by me
looked more appropriate to me.
Please let me know if you still have some question.
>
>
> Thanks
>
> Jacques
>
>
> Author: ashish
>> Date: Thu Sep 11 01:51:39 2008
>> New Revision: 694183
>>
>> URL: http://svn.apache.org/viewvc?rev=694183&view=rev
>> Log:
>> Some UI label change in passwordemail template.
>> Changed ${userLoginId} to ${userLogin.userLoginId}.
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
>> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>>
>> Modified: ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml
>> (original)
>> +++ ofbiz/trunk/applications/ecommerce/config/EcommerceUiLabels.xml Thu
>> Sep 11 01:51:39 2008
>> @@ -977,6 +977,9 @@
>> <value xml:lang="ru">больше чем</value>
>> <value xml:lang="th">มาภภว่า</value>
>> </property>
>> + <property key="CommonNewSmall">
>> + <value xml:lang="en">new</value>
>> + </property>
>> <property key="CommonNewListSubscription">
>> <value xml:lang="en">New List Subscription</value>
>> <value xml:lang="es">Nueva lista de subscripción</value>
>> @@ -1029,6 +1032,9 @@
>> <value xml:lang="it">tuo</value>
>> <value xml:lang="th">ขà¸à¸‡à¸„ุà¸"</value>
>> </property>
>> + <property key="CommonYourCapital">
>> + <value xml:lang="en">Your</value>
>> + </property>
>> <property key="EcommerceAccountLogin">
>> <value xml:lang="en">Your account login is:</value>
>> <value xml:lang="es">Usuario</value>
>>
>> Modified: ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml (original)
>> +++ ofbiz/trunk/applications/ecommerce/data/DemoProduct.xml Thu Sep 11
>> 01:51:39 2008
>> @@ -86,7 +86,7 @@
>>
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_TELL_FRIEND"
>> bodyScreenLocation="component://ecommerce/widget/EmailProductScreens.xml#TellFriend"
>> subject="${sendFrom} has sent you a link!" fromAddress="
>> ofbiztest@yahoo.com"/>
>>
>> - <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_PWD_RETRIEVE"
>> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
>> subject="OFBiz Demo - Password Reminder (${userLoginId})" fromAddress="
>> ofbiztest@yahoo.com"/>
>> + <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_PWD_RETRIEVE"
>> bodyScreenLocation="component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail"
>> subject="OFBiz Demo - Password Reminder (${userLogin.userLoginId})"
>> fromAddress="ofbiztest@yahoo.com"/>
>>
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_QUO_CONFIRM"
>> bodyScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple"
>> xslfoAttachScreenLocation="component://order/widget/ordermgr/QuoteScreens.xml#QuoteReport"
>> subject="OFBiz Demo - Quote Confirmation #${quoteId}" bccAddress="
>> ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>
>>
>>
>> Modified:
>> ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl?rev=694183&r1=694182&r2=694183&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> (original)
>> +++ ofbiz/trunk/applications/securityext/email/default/passwordemail.ftl
>> Thu Sep 11 01:51:39 2008
>> @@ -23,6 +23,6 @@
>> <body>
>> <div>${uiLabelMap.EcommerceThisEmailIsInResponseToYourRequestToHave} <#if
>> useEncryption>${uiLabelMap.EcommerceANew}<#else>${uiLabelMap.CommonYour}</#if>
>> ${uiLabelMap.EcommercePasswordSentToYou}.</div>
>> <br/>
>> - <div>${uiLabelMap.CommonYour} <#if
>> useEncryption>${uiLabelMap.CommonNew}</#if>
>> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
>> + <div>${uiLabelMap.CommonYourCapital} <#if
>> useEncryption>${uiLabelMap.CommonNewSmall}</#if>
>> ${uiLabelMap.EcommercePasswordIs} "${password}"</div>
>> </body>
>> </html>
>>
>>
>>
>