You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/10/04 00:07:54 UTC
[native-toolchain-CR] IMPALA-8978: Fix TLS issues in Centos 6 docker image build
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14366
Change subject: IMPALA-8978: Fix TLS issues in Centos 6 docker image build
......................................................................
IMPALA-8978: Fix TLS issues in Centos 6 docker image build
Everything needs TLSv1.2 now, and the version of nss that ships
with Centos 6.6 is too old. We already knew this and were
installing the nss from Centos 6.8, but we were installing it
after all the yum-install commands. The yum-install commands
now fail with TLS issues, so this installs the new nss before
invoking any other yum-install commands.
Testing:
- Built the redhat6 docker image
Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
---
M docker/redhat6.df
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/66/14366/1
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] IMPALA-8978: Fix TLS issues in Centos 6 docker image build
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14366 )
Change subject: IMPALA-8978: Fix TLS issues in Centos 6 docker image build
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Oct 2019 00:36:09 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8978: Fix Centos 6 docker image build issues
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14366 )
Change subject: IMPALA-8978: Fix Centos 6 docker image build issues
......................................................................
IMPALA-8978: Fix Centos 6 docker image build issues
Everything needs TLSv1.2 now, and the version of nss that ships
with Centos 6.6 is too old. We already knew this and were
installing the nss from Centos 6.8, but we were installing it
after all the yum-install commands. The yum-install commands
now fail with TLS issues, so this installs the new nss before
invoking any other yum-install commands.
Separately, the download for ccache-3.3.3 is failing on Centos 6.
This failure is not detected, so it produces a docker image that
uses the built-in ccache. Unfortunately, there are bugs in that
version of ccache such that cmake does not compile properly. This
makes multiple changes to fix this:
1. This changes the URL to a working URL.
2. This changes postinstall.sh to run the downloads serially
so that it does not miss the error code.
3. This adds a check for the ccache version in
assert-dependencies-present.py
Testing:
- Built all the docker images
- Ran a toolchain build with the new docker images
Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Reviewed-on: http://gerrit.cloudera.org:8080/14366
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M docker/all/assert-dependencies-present.py
M docker/all/postinstall.sh
M docker/redhat6.df
3 files changed, 23 insertions(+), 9 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-8978: Fix Centos 6 docker image build issues
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14366 )
Change subject: IMPALA-8978: Fix Centos 6 docker image build issues
......................................................................
Patch Set 2: Verified+1
Build succeeded with the new docker images.
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Oct 2019 21:43:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8978: Fix Centos 6 docker image build issues
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14366 )
Change subject: IMPALA-8978: Fix Centos 6 docker image build issues
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Oct 2019 20:30:20 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-8978: Fix Centos 6 docker image build issues
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14366
to look at the new patch set (#2).
Change subject: IMPALA-8978: Fix Centos 6 docker image build issues
......................................................................
IMPALA-8978: Fix Centos 6 docker image build issues
Everything needs TLSv1.2 now, and the version of nss that ships
with Centos 6.6 is too old. We already knew this and were
installing the nss from Centos 6.8, but we were installing it
after all the yum-install commands. The yum-install commands
now fail with TLS issues, so this installs the new nss before
invoking any other yum-install commands.
Separately, the download for ccache-3.3.3 is failing on Centos 6.
This failure is not detected, so it produces a docker image that
uses the built-in ccache. Unfortunately, there are bugs in that
version of ccache such that cmake does not compile properly. This
makes multiple changes to fix this:
1. This changes the URL to a working URL.
2. This changes postinstall.sh to run the downloads serially
so that it does not miss the error code.
3. This adds a check for the ccache version in
assert-dependencies-present.py
Testing:
- Built all the docker images
- Ran a toolchain build with the new docker images
Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
---
M docker/all/assert-dependencies-present.py
M docker/all/postinstall.sh
M docker/redhat6.df
3 files changed, 23 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/66/14366/2
--
To view, visit http://gerrit.cloudera.org:8080/14366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I938a949a16eaf3291e765d67fbb1fd8912b8424f
Gerrit-Change-Number: 14366
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>