[GitHub] spark pull request #16308: [SPARK-18936][SQL] Infrastructure for session loc...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16308#discussion_r95340855
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ---
    @@ -512,8 +550,9 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression w
             (c, evPrim, evNull) => s"""$evPrim = UTF8String.fromString(
               org.apache.spark.sql.catalyst.util.DateTimeUtils.dateToString($c));"""
           case TimestampType =>
    +        val tz = ctx.addReferenceObj("timeZone", timeZone)
    --- End diff --
    
    we should use `addReferenceMinorObj` to avoid adding member variables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org