You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 09:25:00 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #36405: [SPARK-39065][SQL] DS V2 Limit push-down should avoid out of memory

cloud-fan commented on code in PR #36405:
URL: https://github.com/apache/spark/pull/36405#discussion_r867811857


##########
docs/sql-data-sources-jdbc.md:
##########
@@ -286,6 +286,15 @@ logging into the data sources.
     <td>read</td>
   </tr>
 
+  <tr>
+    <td><code>maxPushDownLimit</code></td>

Review Comment:
   Shall we make it a SQL config? It's not specific to any query, but more about the driver setup. A per-query option may be an overkill.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org