You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "asl3 (via GitHub)" <gi...@apache.org> on 2023/07/10 19:51:40 UTC

[GitHub] [spark] asl3 opened a new pull request, #41926: [SPARK-44363] [PYTHON] Display percent of unequal rows in DataFrame comparison

asl3 opened a new pull request, #41926:
URL: https://github.com/apache/spark/pull/41926

   ### What changes were proposed in this pull request?
   This PR fixes error message display of percent of unequal rows for unequal DataFrames, in the `assertDataFrameEqual` util function.
   
   
   ### Why are the changes needed?
   The correction is needed to provide accurate error message output.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, the PR modifies user-facing error message for the `assertDataFrameEqual` util function.
   
   
   ### How was this patch tested?
   Modified existing tests in `runtime/python/pyspark/sql/tests/test_utils.py` and `runtime/python/pyspark/sql/tests/connect/test_utils.py`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #41926: [SPARK-44363] [PYTHON] Display percent of unequal rows in DataFrame comparison

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41926:
URL: https://github.com/apache/spark/pull/41926#issuecomment-1630065979

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #41926: [SPARK-44363] [PYTHON] Display percent of unequal rows in DataFrame comparison

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41926: [SPARK-44363] [PYTHON] Display percent of unequal rows in DataFrame comparison
URL: https://github.com/apache/spark/pull/41926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org