[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7421:
URL: https://github.com/apache/cloudstack/pull/7421#discussion_r1168834230


##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4810,9 +4810,12 @@ protected String validateUserData(String userData, HTTPMethod httpmethod) {
     }
 
     @Override
-    @ActionEvent(eventType = EventTypes.EVENT_VM_CREATE, eventDescription = "starting Vm", async = true)
+    @ActionEvent(eventType = EventTypes.EVENT_VM_CREATE, eventDescription = "deploying Vm", async = true)

Review Comment:
   @shwstppr , it seems to me this should not yield an event for `EVENT_VM_CREATE` but for EVENT_VM_START`. The `EVENT_VM_CREATE` should already have been yielded on `_userVmService.createVirtualMachine(this)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org