You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2021/05/14 21:48:05 UTC
[kudu-CR](branch-1.15.x) [master] KUDU-2181 Unhide master change config flag & other improvements
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17450
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements
......................................................................
[master] KUDU-2181 Unhide master change config flag & other improvements
This change:
- Unhides and turns the master Raft change config flag ON by default
- Updates the description of flags that are not passed to the new
master
- Uses sync logging on bringing up the new master to help
debug any issues in startup of the new master
- Updates the wait timeout while bringing up a new master to account
for the higher ntp wait timeout. This timeout is also used for
checking whether the new master's system catalog has caught up
from WAL. So this'll bump up timeout for that case as well. Thought
about introducing separate wait timeout for that case but felt like
exposing too many knobs and user shouldn't care whether time
is being taken for master bringup or catchup from WAL.
Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Reviewed-on: http://gerrit.cloudera.org:8080/17401
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit c5648cf189e0413420a553ad5f51aa8252a1fd6f)
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/tools/tool_action_master.cc
3 files changed, 27 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/17450/1
--
To view, visit http://gerrit.cloudera.org:8080/17450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Gerrit-Change-Number: 17450
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR](branch-1.15.x) [master] KUDU-2181 Unhide master change config flag & other improvements
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17450 )
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Gerrit-Change-Number: 17450
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 15 May 2021 01:37:13 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [master] KUDU-2181 Unhide master change config flag & other improvements
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has removed a vote on this change.
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Gerrit-Change-Number: 17450
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [master] KUDU-2181 Unhide master change config flag & other improvements
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17450 )
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements
......................................................................
Patch Set 1: Verified+1
> Patch Set 1: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/23848/ : FAILURE
Unrelated test failure in RaftConsensusITest.TestSlowFollower
--
To view, visit http://gerrit.cloudera.org:8080/17450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Gerrit-Change-Number: 17450
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 15 May 2021 04:23:13 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [master] KUDU-2181 Unhide master change config flag & other improvements
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17450 )
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements
......................................................................
[master] KUDU-2181 Unhide master change config flag & other improvements
This change:
- Unhides and turns the master Raft change config flag ON by default
- Updates the description of flags that are not passed to the new
master
- Uses sync logging on bringing up the new master to help
debug any issues in startup of the new master
- Updates the wait timeout while bringing up a new master to account
for the higher ntp wait timeout. This timeout is also used for
checking whether the new master's system catalog has caught up
from WAL. So this'll bump up timeout for that case as well. Thought
about introducing separate wait timeout for that case but felt like
exposing too many knobs and user shouldn't care whether time
is being taken for master bringup or catchup from WAL.
Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Reviewed-on: http://gerrit.cloudera.org:8080/17401
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Bankim Bhavsar <ba...@cloudera.com>
(cherry picked from commit c5648cf189e0413420a553ad5f51aa8252a1fd6f)
Reviewed-on: http://gerrit.cloudera.org:8080/17450
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master_service.cc
M src/kudu/tools/tool_action_master.cc
3 files changed, 27 insertions(+), 23 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Bankim Bhavsar: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d
Gerrit-Change-Number: 17450
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)