You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Yi Liu (JIRA)" <ji...@apache.org> on 2015/01/04 05:40:34 UTC
[jira] [Comment Edited] (HADOOP-11455) KMS and Credential CLI
should request confirmation for deletion by default
[ https://issues.apache.org/jira/browse/HADOOP-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263750#comment-14263750 ]
Yi Liu edited comment on HADOOP-11455 at 1/4/15 4:40 AM:
---------------------------------------------------------
I agree that it's good get confirmation for deletion by default.
The patch looks good to me, just 1 small nit, +1 after addressing.
*1.* we have following change in KeyShell.java
{code}
- + " key: " + keyName + " from KeyProvider "
- + provider + ". Continue?:");
+ + " key " + keyName + " from KeyProvider "
+ + provider + ". Continue? ");
{code}
Could we make the same change in CredentialShell.java?
was (Author: hitliuyi):
I agree that it's good get confirmation for deletion by default.
The patch looks good to me, just 1 small nit, +1 after addressing.
*1.* we have following change in KeyShell.java
{code}
- + " key: " + keyName + " from KeyProvider "
- + provider + ". Continue?:");
+ + " key " + keyName + " from KeyProvider "
+ + provider + ". Continue? ");
{code}
Could we make it consistent in CredentialShell.java?
> KMS and Credential CLI should request confirmation for deletion by default
> --------------------------------------------------------------------------
>
> Key: HADOOP-11455
> URL: https://issues.apache.org/jira/browse/HADOOP-11455
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.7.0
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Priority: Minor
> Attachments: HADOOP-11455.000.patch
>
>
> The hadoop key delete and hadoop credential delete currently only ask for confirmation of the delete if -i is specified. Asking for confirmation should be the default action for both.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)