You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 07:01:54 UTC

[GitHub] [airflow] kushsharma opened a new pull request #10622: Remove redundant argument doc in KubePodOperator

kushsharma opened a new pull request #10622:
URL: https://github.com/apache/airflow/pull/10622


   `do_xcom_push` is mentioned twice in the KubernetesPodOperator argument documentation, which is line 107.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kushsharma closed pull request #10622: Remove redundant argument doc in KubePodOperator

Posted by GitBox <gi...@apache.org>.

kushsharma closed pull request #10622:
URL: https://github.com/apache/airflow/pull/10622


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10622: Remove redundant argument doc in KubePodOperator

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10622:
URL: https://github.com/apache/airflow/pull/10622#issuecomment-682364417

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #10622: Remove redundant argument doc in KubePodOperator

Posted by GitBox <gi...@apache.org>.

XD-DENG commented on pull request #10622:
URL: https://github.com/apache/airflow/pull/10622#issuecomment-682441727


   Hi @kushsharma, thanks for your PR. Normally PR is raised against “master” branch, and branch “v1-10-stable“ is for release.
   
   The issue you try to fix here was already fixed in master branch (the file is under “providers/cncf/kubernetes/“ now).
   
   Thanks again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org