You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/07/02 01:18:45 UTC

[jira] Commented: (THRIFT-42) javabean generated code assumes camel-case and makes very ugly getters and setters if not camel cased properly

    [ https://issues.apache.org/jira/browse/THRIFT-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609743#action_12609743 ] 

Bryan Duxbury commented on THRIFT-42:
-------------------------------------

What if we added a command line switch that could select the case used to generate? Something like --not-camel-case? Then it would just be a case of implementing the underscored-style name generation. 

Ideally it wouldn't have to be a command line option. I'd like it if we had compiler directives or annotations or something that let us make these options part of the .thrift file itself. (I am aware that would be a nontrivial operation, though.)

> javabean generated code assumes camel-case and makes very ugly getters and setters if not camel cased properly
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-42
>                 URL: https://issues.apache.org/jira/browse/THRIFT-42
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Trivial
>
> Let's say you name your fields in underscored lower case (my_cool_field). The bean-style generator only upcases the first character of the name and mashes it onto get, set, etc. You end up with something that looks like "getMy_cool_field". This gross hybrid is pretty terrible. 
> I propose that we either add a case-style compiler option, or at least try and detect the casing and convert it appropriately.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.