You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2009/10/13 01:21:31 UTC
[jira] Created: (MAPREDUCE-1093) Java assertion failures triggered
by tests
Java assertion failures triggered by tests
------------------------------------------
Key: MAPREDUCE-1093
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
Project: Hadoop Map/Reduce
Issue Type: Test
Reporter: Eli Collins
While running the tests with java asserts enabled the following two asserts fired:
{code}
testStateRefresh in TestQueueManager:
try{
Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
assert(job.isSuccessful()); <==========
}catch(Exception e){
{code}
{code}
runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
for (TaskCompletionEvent tce : taskComplEvents) {
// Every task HAS to fail
assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
.getTaskStatus() == TaskCompletionEvent.Status.FAILED);
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAPREDUCE-1093) Java assertion failures triggered
by tests
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball reassigned MAPREDUCE-1093:
----------------------------------------
Assignee: Aaron Kimball
> Java assertion failures triggered by tests
> ------------------------------------------
>
> Key: MAPREDUCE-1093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Eli Collins
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1093.patch
>
>
> While running the tests with java asserts enabled the following two asserts fired:
> {code}
> testStateRefresh in TestQueueManager:
> try{
> Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
> assert(job.isSuccessful()); <==========
> }catch(Exception e){
> {code}
> {code}
> runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
> for (TaskCompletionEvent tce : taskComplEvents) {
> // Every task HAS to fail
> assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
> .getTaskStatus() == TaskCompletionEvent.Status.FAILED);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1093) Java assertion failures
triggered by tests
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835478#action_12835478 ]
Aaron Kimball commented on MAPREDUCE-1093:
------------------------------------------
I agree; I would rather see MAPREDUCE-1092 included sooner rather than later, as the failure is genuine. I've filed MAPREDUCE-1506 for this.
> Java assertion failures triggered by tests
> ------------------------------------------
>
> Key: MAPREDUCE-1093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Eli Collins
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1093.patch
>
>
> While running the tests with java asserts enabled the following two asserts fired:
> {code}
> testStateRefresh in TestQueueManager:
> try{
> Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
> assert(job.isSuccessful()); <==========
> }catch(Exception e){
> {code}
> {code}
> runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
> for (TaskCompletionEvent tce : taskComplEvents) {
> // Every task HAS to fail
> assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
> .getTaskStatus() == TaskCompletionEvent.Status.FAILED);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1093) Java assertion failures triggered
by tests
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1093:
-------------------------------------
Attachment: MAPREDUCE-1093.patch
I've poked around the code for a while to try to figure out what's wrong here. TestQueueManager no longer seems to fail; perhaps in the intervening weeks since this issue was filed, a bug in the QueueManager has been fixed.
TestTaskTrackerMemoryManager fails sporadically for me; there's an error condition such that sometimes one task will be marked TIPFAILED while the other task in the job is marked as SUCCEEDED.
This patch disables the failing assert in TestTaskTrackerMemoryManager. Since it was never run before anyway, it is not terribly problematic for it to be disabled now, until the semantics of this test and its underlying code can be established. In the meantime, this will allow us to commit MAPREDUCE-1092 and enable better assertion-checking coverage on the rest of the MapReduce tree.
> Java assertion failures triggered by tests
> ------------------------------------------
>
> Key: MAPREDUCE-1093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Eli Collins
> Attachments: MAPREDUCE-1093.patch
>
>
> While running the tests with java asserts enabled the following two asserts fired:
> {code}
> testStateRefresh in TestQueueManager:
> try{
> Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
> assert(job.isSuccessful()); <==========
> }catch(Exception e){
> {code}
> {code}
> runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
> for (TaskCompletionEvent tce : taskComplEvents) {
> // Every task HAS to fail
> assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
> .getTaskStatus() == TaskCompletionEvent.Status.FAILED);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1093) Java assertion failures
triggered by tests
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833818#action_12833818 ]
Vinod K V commented on MAPREDUCE-1093:
--------------------------------------
bq. This patch disables the failing assert in TestTaskTrackerMemoryManager.
Instead can we just let it be and file a new issue, attaching any test logs if possible there? I quickly looked at the code and seemed that it should work the way it is expressed in code.
So, I am leaning towards letting it be and going ahead with MAPREDUCE-1092. If you already have some logs, you can create a new issue rightaway; I can look into it..
> Java assertion failures triggered by tests
> ------------------------------------------
>
> Key: MAPREDUCE-1093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Eli Collins
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1093.patch
>
>
> While running the tests with java asserts enabled the following two asserts fired:
> {code}
> testStateRefresh in TestQueueManager:
> try{
> Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
> assert(job.isSuccessful()); <==========
> }catch(Exception e){
> {code}
> {code}
> runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
> for (TaskCompletionEvent tce : taskComplEvents) {
> // Every task HAS to fail
> assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
> .getTaskStatus() == TaskCompletionEvent.Status.FAILED);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAPREDUCE-1093) Java assertion failures triggered
by tests
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball resolved MAPREDUCE-1093.
--------------------------------------
Resolution: Invalid
> Java assertion failures triggered by tests
> ------------------------------------------
>
> Key: MAPREDUCE-1093
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1093
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Reporter: Eli Collins
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1093.patch
>
>
> While running the tests with java asserts enabled the following two asserts fired:
> {code}
> testStateRefresh in TestQueueManager:
> try{
> Job job = submitSleepJob(10, 2, 10, 10, true,null, "default" );
> assert(job.isSuccessful()); <==========
> }catch(Exception e){
> {code}
> {code}
> runJobExceedingMemoryLimit in TestTaskTrackerMemoryManager:
> for (TaskCompletionEvent tce : taskComplEvents) {
> // Every task HAS to fail
> assert (tce.getTaskStatus() == TaskCompletionEvent.Status.TIPFAILED || tce <==========
> .getTaskStatus() == TaskCompletionEvent.Status.FAILED);
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.