[GitHub] [superset] betodealmeida commented on a change in pull request #17969: chore(dbc-ui): encode characters before building sqlalchemy uri

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #17969:
URL: https://github.com/apache/superset/pull/17969#discussion_r780479916



##########
File path: superset/databases/utils.py
##########
@@ -101,3 +103,7 @@ def get_table_metadata(
         "indexes": keys,
         "comment": table_comment,
     }
+
+
+def encode_parameters(parameters: Dict[str, Any]) -> Dict[str, Any]:
+    return {k: urllib.parse.quote(v) for k, v in parameters.items()}

Review comment:
       Let's use `quote_plus` here, since it's what SQLAlchemy recommends: https://docs.sqlalchemy.org/en/14/core/engines.html?highlight=quote_plus#database-urls




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org