You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2026/10/21 03:59:27 UTC
[PR] [Docs] Consolidate repository agent instructions in AGENTS.md [iotdb]
JackieTien97 opened a new pull request, #18952:
URL: https://github.com/apache/iotdb/pull/18952
## Description
The root `AGENTS.md` is a symlink to `CLAUDE.md`, so shared repository guidance depends on symlink support and a tool-specific file. Replace it with a regular `AGENTS.md` and remove the root `CLAUDE.md`, preserving the license header and all existing guidance below the introduction.
This implements the October 20 dev@iotdb.apache.org proposal, **[DISCUSS] Consolidate repository agent instructions in AGENTS.md** ([mailing-list archive](https://lists.apache.org/list.html?dev@iotdb.apache.org:2026-10)).
- Use a tool-neutral title and introduction, with a link to contributor setup notes.
- Document Claude Code version requirements, instruction-file precedence, the Project instructions setting, and how to verify loading in `CONTRIBUTING.md`.
- Update the threat model's references and remove the obsolete RAT exclusion so `AGENTS.md` receives normal license checks.
## Validation
- `git diff --check` passed.
- Compared the migrated file against the previous `CLAUDE.md`: only the title and introduction changed; module-level instructions are unchanged.
- Verified the regular-file mode, removal of `CLAUDE.md`, local documentation links and anchor, and POM XML.
- `mvn -B -N apache-rat:check` with `rat.includesFile` limited to the four changed files passed: 4 approved licenses, 0 unknown or unapproved.
- No application tests were run; this changes documentation and license-check configuration only.
This PR has:
- [x] been self-reviewed.
- [x] added documentation for the changed instruction-loading behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Docs] Consolidate repository agent instructions in AGENTS.md [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #18952:
URL: https://github.com/apache/iotdb/pull/18952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Docs] Consolidate repository agent instructions in AGENTS.md [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #18952:
URL: https://github.com/apache/iotdb/pull/18952#issuecomment-6308506366
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18952?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 47.06%. Comparing base ([`ddb1741`](https://app.codecov.io/gh/apache/iotdb/commit/ddb1741118b2d5b0cb7f0734f5a8f57ca3fd55a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`000b215`](https://app.codecov.io/gh/apache/iotdb/commit/000b215868182939fd6230a791dae7546b64e30c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18952 +/- ##
============================================
+ Coverage 47.00% 47.06% +0.06%
Complexity 729 729
============================================
Files 5539 5539
Lines 405138 405207 +69
Branches 53012 53028 +16
============================================
+ Hits 190424 190723 +299
+ Misses 214714 214484 -230
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18952?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org