You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/05/22 16:10:17 UTC
[GitHub] nifi-minifi-cpp pull request #336: MINIFICPP-498 Test newer compiler (gcc >=...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/336
MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of …
…Docker image) in travis
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-498
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #336
----
commit ace0d0f983147d582287d767f3db5afd121e2356
Author: Andrew I. Christianson <an...@...>
Date: 2018-05-22T14:42:50Z
MINIFICPP-498 Test newer compiler (gcc >= 6) (and also test build of Docker image) in travis
----
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Ticket description for https://issues.apache.org/jira/browse/MINIFICPP-503, I'm guessing? I'll wait to review this one until 498 is rebased upon this, then.
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Rebased.
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
The general build covers an older/LTS Ubuntu which is more conservative. This way we cover old as well as new compilers.
---
[GitHub] nifi-minifi-cpp pull request #336: MINIFICPP-498 Test newer compiler (gcc >=...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/336
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Travis fail seems to be unrelated (segfault in C2 components).
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
This is ready for review. The build fails due to MINIFICPP-503. The custom script is because we're building in docker (make docker). The reason for this additional build is outlined in the ticket description.
---
[GitHub] nifi-minifi-cpp issue #336: MINIFICPP-498 Test newer compiler (gcc >= 6) (an...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/336
Is this something to review or just that you are testing? Why is there a custom script for that release.
---