You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/10 06:21:52 UTC
[GitHub] [apisix-ingress-controller] Donghui0 opened a new issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Donghui0 opened a new issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674
### Issue description
When k8s service is deleted, the APISIX Upstream nodes field is not cleared
### Environment
* your apisix-ingress-controller version: v1.2
* your Kubernetes cluster version: v1.16
### Minimal test code / Steps to reproduce the issue
1. delete k8s service.
2. query APISIX upstream nodes field
### What's the actual result? (including assertion message & call stack if applicable)
remaining history of upstream node
### What's the expected result?
upstream nodes cleared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-917420899
This is a known behavior, see https://github.com/apache/apisix-ingress-controller/blob/1e1be7401ba3707ba660a7d61df5118fc5725eff/pkg/ingress/controller.go#L529.
From the proxy point of view, the result is similar, requests will be failed no matter whether we clean the nodes.
Of course, we do need make some reactions for the Services/Endpoints delete events, PR's welcome to optimize it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-920496033
> I hope this can have an overall solution and then coding.
>
> Upstream management in the ingress controller has become more complicated, it will be affected in many ways，for example, the resources of k8s svc , ApisixUpstream and ApisixRoute ，There are subset-related configurations in ApisixRoute and ApisixUpstream.
It doesn't affect ApisixRoute, but it will affect multiple Upstream objects in APISIX due to subset mechanics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-919718803
I hope this can have an overall solution and then coding.
Upstream management in the ingress controller has become more complicated, it will be affected in many ways，for example, the resources of k8s svc , ApisixUpstream and ApisixRoute ，There are subset-related configurations in ApisixRoute and ApisixUpstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-918184848
> > This is a known behavior, see
> > https://github.com/apache/apisix-ingress-controller/blob/1e1be7401ba3707ba660a7d61df5118fc5725eff/pkg/ingress/controller.go#L529
> >
> > .
> > From the proxy point of view, the result is similar, requests will be failed no matter whether we clean the nodes.
> > Of course, we do need to make some reactions for the Services/Endpoints delete events, PR's welcome to optimize it.
>
> There will be problems in special scenarios: the node ip is allocated by other containers.
Fair enough, PR's welcome to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-919585111
Thanks for your feedback, it is not difficult to fix it, welcome to submit a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-917420899
This is a known behavior, see https://github.com/apache/apisix-ingress-controller/blob/1e1be7401ba3707ba660a7d61df5118fc5725eff/pkg/ingress/controller.go#L529.
From the proxy point of view, the result is similar, requests will be failed no matter whether we clean the nodes.
Of course, we do need to make some reactions for the Services/Endpoints delete events, PR's welcome to optimize it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #674: bug: When k8s service is deleted, the APISIX Upstream nodes field is not cleared
Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #674:
URL: https://github.com/apache/apisix-ingress-controller/issues/674#issuecomment-918120079
> This is a known behavior, see
>
> https://github.com/apache/apisix-ingress-controller/blob/1e1be7401ba3707ba660a7d61df5118fc5725eff/pkg/ingress/controller.go#L529
>
> .
> From the proxy point of view, the result is similar, requests will be failed no matter whether we clean the nodes.
>
> Of course, we do need to make some reactions for the Services/Endpoints delete events, PR's welcome to optimize it.
There will be problems in special scenarios: the node ip is allocated by other containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org