You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/01/14 11:48:55 UTC

[GitHub] [tomee-patch-plugin] jeanouii commented on pull request #5: Exclusion list implemented in Transformation to preserve jar signature

jeanouii commented on pull request #5:
URL: https://github.com/apache/tomee-patch-plugin/pull/5#issuecomment-1013051606


   Hi Cesar,
   
   A couple of comments here
   
   - we should always skip signed jars. Patching those will always fail (goal of the signature). We can have a force patch signed jars flag for testing purpose, but it should be off by default
   
   - the skip jars feature is a good one. Even though we have a predefined list of jars we know we can exclude, it would be great to allow the user to redefine it so we avoid further updates to the plugin and releases.
   
   
   Do you mind giving it a try?
   Otherwise, we can merge this one and I can give it a try after


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org