[GitHub] [spark] squito commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.

[GitBox <gi...@apache.org>]

squito commented on issue #24704: [SPARK-20286][core] Improve logic for timing out executors in dynamic allocation.
URL: https://github.com/apache/spark/pull/24704#issuecomment-497794492
 
 
   > one thing I was thinking is that we don't have any tests on the handling when the CGSB decides to not kill an executor. That test really would need to go in ExecutorAllocationManagerSuite, turn off the dynamic allocation testing config, and mock the cgsb
   
   actually, that is totally wrong -- you can do this test in ExecutionMonitorSuite, just be interleaving calls to timedOutExecutors(), executorsKilled(), onTaskStart(), & executorsRemoved().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org