Re: svn commit: rev 7295 - trunk/build/generator

["Daniel L. Rall" <dl...@finemaltcoding.com>]

rey4@tigris.org wrote:
...
> Log:
> Get skipped sections to work again so gen-make can run without
> --with-httpd option.
> 
> * build/generator/gen_base.py
>   (Generator.find_sections): 
>     ignore skipped section names
> 
> Modified: trunk/build/generator/gen_base.py
> ==============================================================================
> --- trunk/build/generator/gen_base.py	(original)
> +++ trunk/build/generator/gen_base.py	Sat Oct  4 08:37:36 2003
> @@ -95,7 +95,8 @@
>      """Return a list of section objects from a string of section names."""
>      sections = [ ]
>      for section_name in string.split(section_list):
> -      sections.append(self.sections[section_name])
> +      if section_name not in self.skip_sections:
> +        sections.append(self.sections[section_name])
>      return sections
>  
>    def compute_hdr_deps(self):


The following post by Martin Furter appears to be related to this commit.  His 
change looks good to me, +1:


"Today i wanted to update svn and got an error in
build/generator/gen_base.py:
TypeError: 'in' or 'not in' needs sequence right argument
ERROR: gen-make.py failed

Here's a patch:

Index: build/generator/gen_base.py
===================================================================
--- build/generator/gen_base.py (revision 7308)
+++ build/generator/gen_base.py (working copy)
@@ -95,7 +95,7 @@
      """Return a list of section objects from a string of section
names."""
      sections = [ ]
      for section_name in string.split(section_list):
-      if section_name not in self.skip_sections:
+      if not self.skip_sections.has_key( section_name ):
          sections.append(self.sections[section_name])
      return sections


Thanks
Martin"


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org