You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/09/07 04:53:02 UTC
[GitHub] [incubator-doris] qzsee opened a new pull request #6580: [FOLLOWUP] create table like clause support copy rollup
qzsee opened a new pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580
## Proposed changes
for issue #6474
create table test.table1 like test.table with rollup (r1,r2) -- copy some rollup
create table test.table1 like test.table with rollup -- copy all rollup
create table test.table1 like test.table -- only copy base table
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 merged pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
liutang123 merged pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 closed pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
liutang123 closed pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580#issuecomment-928657496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 commented on a change in pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
liutang123 commented on a change in pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580#discussion_r703225443
##########
File path: fe/fe-core/src/test/java/org/apache/doris/catalog/CreateTableLikeTest.java
##########
@@ -110,10 +113,10 @@ private static void checkCreateOlapTableLike(String createTableSql, String creat
String newTblName, String existedTblName, int rollupSize) throws Exception {
createTable(createTableSql);
createTableLike(createTableLikeSql);
- Database newDb = Catalog.getCurrentCatalog().getDbOrDdlException("default_cluster:" + newDbName);
- Database existedDb = Catalog.getCurrentCatalog().getDbOrDdlException("default_cluster:" + existedDbName);
- OlapTable newTbl = (OlapTable) newDb.getTableOrDdlException(newTblName);
- OlapTable existedTbl = (OlapTable) existedDb.getTableOrDdlException(existedTblName);
+ Database newDb = Catalog.getCurrentCatalog().getDb("default_cluster:" + newDbName);
Review comment:
Why change here?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableLikeStmt.java
##########
@@ -99,7 +105,15 @@ public void analyze(Analyzer analyzer) throws UserException {
@Override
public String toSql() {
- return String.format("CREATE TABLE %s LIKE %s", tableName.toSql(), existedTableName.toSql());
+ StringBuilder sb = new StringBuilder();
+ sb.append("CREATE TABLE ").append(tableName.toSql()).append(" LIKE ").append(existedTableName.toSql());
+ if (withAllRollup && rollupNames == null){
+ sb.append(" WITH ROLLUP");
+ }
+ if (!withAllRollup && rollupNames != null){
Review comment:
if (!withAllRollup && !CollectionUtils.isEmpty(rollupNames)) {
##########
File path: fe/fe-core/src/test/java/org/apache/doris/catalog/CreateTableLikeTest.java
##########
@@ -123,10 +126,10 @@ private static void checkCreateMysqlTableLike(String createTableSql, String crea
createTable(createTableSql);
createTableLike(createTableLikeSql);
- Database newDb = Catalog.getCurrentCatalog().getDbOrDdlException("default_cluster:" + newDbName);
- Database existedDb = Catalog.getCurrentCatalog().getDbOrDdlException("default_cluster:" + existedDbName);
- MysqlTable newTbl = (MysqlTable) newDb.getTableOrDdlException(newTblName);
- MysqlTable existedTbl = (MysqlTable) existedDb.getTableOrDdlException(existedTblName);
+ Database newDb = Catalog.getCurrentCatalog().getDb("default_cluster:" + newDbName);
Review comment:
here？
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableLikeStmt.java
##########
@@ -99,7 +105,15 @@ public void analyze(Analyzer analyzer) throws UserException {
@Override
public String toSql() {
- return String.format("CREATE TABLE %s LIKE %s", tableName.toSql(), existedTableName.toSql());
+ StringBuilder sb = new StringBuilder();
+ sb.append("CREATE TABLE ").append(tableName.toSql()).append(" LIKE ").append(existedTableName.toSql());
+ if (withAllRollup && rollupNames == null){
Review comment:
if (withAllRollup && CollectionUtils.isEmpty(rollupNames)) {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] liutang123 commented on pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
liutang123 commented on pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580#issuecomment-914889059
Please rebase to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6580: [FOLLOWUP] create table like clause support copy rollup
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6580:
URL: https://github.com/apache/incubator-doris/pull/6580#issuecomment-928657496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org