You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Raúl Cumplido (Jira)" <ji...@apache.org> on 2022/09/06 14:48:00 UTC
[jira] [Updated] (ARROW-17632) [Python][C++] Add details of where is lib arrow being found during build
[ https://issues.apache.org/jira/browse/ARROW-17632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raúl Cumplido updated ARROW-17632:
----------------------------------
Description:
As discussed here:
[https://github.com/apache/arrow/pull/13892#discussion_r963587046]
We used to show information of where Arrow was being found during build:
{code:java}
message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") {code}
We should add back the messages to {{ArrowConfig.cmake.in.}}
As proposed on the comment if we want to add {{{}message(STATUS ...){}}}, it's better that we check {{Arrow_FIND_QUIETLY}} like:
{code:java}
if(NOT Arrow_FIND_QUIETLY)
message(STATUS ...)
endif(){code}
{{Arrow_FIND_QUIETLY}} is {{TRUE}} only when an user specify {{QUIET}} explicitly like {{{}find_package(Arrow QUIET){}}}.
was:
As discussed here:
[https://github.com/apache/arrow/pull/13892#discussion_r963587046]
We used to show information of where Arrow was being found during build:
{code:java}
message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") {code}
We should add back the messages{{{}{}}} to {{ArrowConfig.cmake.in.}}
As proposed on the comment if we want to add {{{}message(STATUS ...){}}}, it's better that we check {{Arrow_FIND_QUIETLY}} like:
{code:java}
if(NOT Arrow_FIND_QUIETLY)
message(STATUS ...)
endif(){code}
{{Arrow_FIND_QUIETLY}} is {{TRUE}} only when an user specify {{QUIET}} explicitly like {{{}find_package(Arrow QUIET){}}}.
> [Python][C++] Add details of where is lib arrow being found during build
> ------------------------------------------------------------------------
>
> Key: ARROW-17632
> URL: https://issues.apache.org/jira/browse/ARROW-17632
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++, Python
> Reporter: Raúl Cumplido
> Priority: Major
>
> As discussed here:
> [https://github.com/apache/arrow/pull/13892#discussion_r963587046]
> We used to show information of where Arrow was being found during build:
> {code:java}
> message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
> message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
> message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
> message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
> message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
> message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") {code}
> We should add back the messages to {{ArrowConfig.cmake.in.}}
> As proposed on the comment if we want to add {{{}message(STATUS ...){}}}, it's better that we check {{Arrow_FIND_QUIETLY}} like:
> {code:java}
> if(NOT Arrow_FIND_QUIETLY)
> message(STATUS ...)
> endif(){code}
> {{Arrow_FIND_QUIETLY}} is {{TRUE}} only when an user specify {{QUIET}} explicitly like {{{}find_package(Arrow QUIET){}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)