You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/08/14 00:31:18 UTC
[GitHub] [accumulo] keith-turner opened a new pull request #1683: Adds test for multiple start events in WAL #1675
keith-turner opened a new pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683#issuecomment-676480434
@milleruntime the thing I noticed was `tablet.getNextMapFilename()` throws an IOException. Moving that into the while loop adds another function to the while loop that throws IOException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
ctubbsii closed pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683#issuecomment-673840121
I closed / re-opened this PR to force the QA checks to run again after the main branch was updated. I expected the PR to sync automatically when main was updated, but it didn't seem to, so this forces it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683#issuecomment-676472670
> Actually, the fix I did in #1675 shouldn't affect how many start events get written to the WAL correct? You just thought of this scenario while looking at that part of the code?
@milleruntime that is correct. The while loop that could cause multiple start events already existed. The changes you introduced added another exception scenario that could could cause multiple start events. However there were pre-existing exception scenarios that could cause multiple start events.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
keith-turner merged pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner edited a comment on pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
keith-turner edited a comment on pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683#issuecomment-676480434
@milleruntime the thing I noticed was `tablet.getNextMapFilename()` throws an IOException. Moving that into the while loop adds another function to the while loop that throws IOException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1683: Adds test for multiple start events in WAL #1675
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1683:
URL: https://github.com/apache/accumulo/pull/1683#issuecomment-674053427
Actually, the fix I did in #1675 shouldn't affect how many start events get written to the WAL correct? You just thought of this scenario while looking at that part of the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org