You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/29 08:16:23 UTC
[GitHub] [iotdb] ericpai opened a new pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
ericpai opened a new pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai edited a comment on pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai edited a comment on pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#issuecomment-1002451261
@HTHou PTAL. This PR fixes some unexpected slow tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#issuecomment-1002451261
@HTHou PTAL. This PR increases some unexpected slow tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776225361
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
In the `waitAllCompactionFinish()` it will wait until `taskExecutionPool.getActiveCount() == 0 && taskExecutionPool.getQueue().size() == 0`. So I don't know what the `sleep()` are waiting for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776218610
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
Why do you remove it? I remember the tests may fail if not sleep here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776225361
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
In the `waitAllCompactionFinish()` it will wait until `taskExecutionPool.getActiveCount() == 0 && taskExecutionPool.getQueue().size() == 0`. So I don't know what the `sleep()` is waiting for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776331044
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
Thanks! I have deleted this test case in the current PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] THUMarkLau commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
THUMarkLau commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776236996
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
`testRestartCompaction` can be removed in 0.13, because we redesigned and implemented the Compaction module. The amount of data inserted in this test does not trigger a compaction. There are more detailed tests of restarting a Compaction than this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on a change in pull request #4657: [IOTDB-2224] Accelerate tests by using batch insert
Posted by GitBox <gi...@apache.org>.
ericpai commented on a change in pull request #4657:
URL: https://github.com/apache/iotdb/pull/4657#discussion_r776225828
##########
File path: integration/src/test/java/org/apache/iotdb/db/integration/IoTDBRestartIT.java
##########
@@ -434,7 +434,6 @@ public void testRestartCompaction()
try {
CompactionTaskManager.getInstance().waitAllCompactionFinish();
- Thread.sleep(10000);
Review comment:
@THUMarkLau This is relatived to your work. Could you explain the design of this test case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org