You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "serhiy-bzhezytskyy (via GitHub)" <gi...@apache.org> on 2026/10/06 14:54:50 UTC
[PR] SOLR-18510: Port AssertTool to picocli [solr]
serhiy-bzhezytskyy opened a new pull request, #5036:
URL: https://github.com/apache/solr/pull/5036
https://issues.apache.org/jira/browse/SOLR-18510
# Description
Adds the picocli code path for `bin/solr assert`, next to the commons-cli one. `test_auth.bats` uses `assert` to wait for startup, so it could not join the picocli suite until now.
# Solution
`AssertTool` gets its annotated options and `callTool()` and is registered in `SolrCLI`; the commons-cli path is unchanged. Written with Claude Code.
# Tests
`AssertToolPicocliTest` runs the existing `AssertToolTest` through picocli. `test_auth.bats` passes under both parsers and is added to `integrationTestsPicocli`; `check -x test` is clean (rat skipped).
# Checklist
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18510: Port AssertTool to picocli [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #5036:
URL: https://github.com/apache/solr/pull/5036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org