[cordova-lib] branch master updated: Remove unnecessary spy (#763)

[ra...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git


The following commit(s) were added to refs/heads/master by this push:
     new 6f153bb  Remove unnecessary spy (#763)
6f153bb is described below

commit 6f153bb93eb2d659a5111eaf4df07ad902a59eb9
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sat Apr 13 11:42:33 2019 +0200

    Remove unnecessary spy (#763)
    
    The stubbing is not actually needed for the tests. It rather causes problems if the tests are using an up-to-date cordova-android as that currently requires ActionStack.prototype.process to return a Q instance.
---
 integration-tests/plugman_uninstall.spec.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/integration-tests/plugman_uninstall.spec.js b/integration-tests/plugman_uninstall.spec.js
index 052d36a..581c0d1 100644
--- a/integration-tests/plugman_uninstall.spec.js
+++ b/integration-tests/plugman_uninstall.spec.js
@@ -21,7 +21,7 @@ const fs = require('fs-extra');
 const path = require('path');
 const rewire = require('rewire');
 
-const { ActionStack, PluginInfo, events } = require('cordova-common');
+const { PluginInfo, events } = require('cordova-common');
 const common = require('../spec/common');
 const install = require('../src/plugman/install');
 const platforms = require('../src/platforms/platforms');
@@ -96,8 +96,6 @@ describe('plugman/uninstall', () => {
 
         beforeEach(function () {
             setupProject('uninstall.test');
-
-            spyOn(ActionStack.prototype, 'process').and.returnValue(Promise.resolve());
         });
 
         describe('success', function () {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org