You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Jeff86 <gi...@git.apache.org> on 2015/07/12 14:00:26 UTC
[GitHub] cordova-plugin-camera pull request: Update CameraLauncher.java
GitHub user Jeff86 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/107
Update CameraLauncher.java
Replace black background to white background for transparent pics from galery
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jeff86/cordova-plugin-camera patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 545defff0a2e425958aa78f04d473a25856caeff
Author: Jeff86 <jf...@gmail.com>
Date: 2015-07-12T11:59:31Z
Update CameraLauncher.java
Replace black background to white background for transparent pics from galery
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Update CameraLauncher.java
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/107#issuecomment-149170808
@Jeff86, could you please explain the rationale of this change? For me it looks like unrelated to plugin functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Update CameraLauncher.java
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Update CameraLauncher.java
Posted by Jeff86 <gi...@git.apache.org>.
Github user Jeff86 commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/107#issuecomment-149180741
@vladimir-kotikov thanks for your comment.
This plugin propose to take pictures from gallery, no-one wants an imported GIF with transparent background going black. We mainly use white as a standard replacement color for transparent layer and my update makes it fit the current standard.
The rational of this change is to fit current standards, make life easier for users and propose a tested and working way to handle a usual issue for developers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Update CameraLauncher.java
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/107#issuecomment-149187990
There are a number of issues with this:
* IMO the image editing is out of this plugin's scope
* This change solves your problem, however other devs might want to use images from gallery as-is.
* Image processing causes a major performance gap and leads to bad UX
Sorry, but I'm not sure we should merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org