You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/06/11 15:50:41 UTC
[GitHub] [samza] vjagadish1989 commented on a change in pull request #1040:
SAMZA-2199: [Scala cleanup] Convert MetricsConfig to Java
vjagadish1989 commented on a change in pull request #1040: SAMZA-2199: [Scala cleanup] Convert MetricsConfig to Java
URL: https://github.com/apache/samza/pull/1040#discussion_r292529942
##########
File path: samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
##########
@@ -83,12 +83,11 @@ class MetricsSnapshotReporterFactory extends MetricsReporterFactory with Logging
info("Got serde %s." format serde)
- val pollingInterval: Int = config
- .getMetricsSnapshotReporterInterval(name)
+ val pollingInterval: Int = metricsConfig.getMetricsSnapshotReporterInterval(name)
info("Setting polling interval to %d" format pollingInterval)
- val blacklist = config.getMetricsSnapshotReporterBlacklist(name)
+ val blacklist = JavaOptionals.toRichOptional(metricsConfig.getMetricsSnapshotReporterBlacklist(name)).toOption
Review comment:
possibly make this a util?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services