You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2018/08/03 22:00:44 UTC
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11117
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
IMPALA-7394: Don't print stack trace in ExpireSessions()
When sessions expire, ExpireSessions() may create excessive amount
of log spew due to printing of the stack traces esp when there are
a massive amount of sessions expiring at the same time. This stack
crawling also unnecessarily extends the critical section under the
session_state_map_lock_, increasing the contention for that lock.
This change converts the use of Status() to Status::Expected() to
remove the unnecessary stack crawl.
Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/11117/1
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2920/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 22:30:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2920/
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 01:43:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 21:23:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/180/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 22:35:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 1:
Build failed due to IMPALA-7328
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 18:11:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Aug 2018 22:06:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
IMPALA-7394: Don't print stack trace in ExpireSessions()
When sessions expire, ExpireSessions() may create excessive amount
of log spew due to printing of the stack traces esp when there are
a massive amount of sessions expiring at the same time. This stack
crawling also unnecessarily extends the critical section under the
session_state_map_lock_, increasing the contention for that lock.
This change converts the use of Status() to Status::Expected() to
remove the unnecessary stack crawl.
Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Reviewed-on: http://gerrit.cloudera.org:8080/11117
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2922/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 18:12:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7394: Don't print stack trace in ExpireSessions()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11117 )
Change subject: IMPALA-7394: Don't print stack trace in ExpireSessions()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29cb143af96e2eef45479a03365d8f49a2ee2dfa
Gerrit-Change-Number: 11117
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Aug 2018 18:12:13 +0000
Gerrit-HasComments: No