You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ac...@apache.org on 2020/03/16 14:52:28 UTC

[camel] 03/04: Try-with-resources: Lets use in the catalog-karaf-provider

This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit adc6964c57c3bc87f9e023c1b67f90cb4a1878c6
Author: Andrea Cosentino <an...@gmail.com>
AuthorDate: Mon Mar 16 15:47:40 2020 +0100

    Try-with-resources: Lets use in the catalog-karaf-provider
---
 .../camel/catalog/karaf/KarafRuntimeProvider.java    | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/catalog/camel-catalog-provider-karaf/src/main/java/org/apache/camel/catalog/karaf/KarafRuntimeProvider.java b/catalog/camel-catalog-provider-karaf/src/main/java/org/apache/camel/catalog/karaf/KarafRuntimeProvider.java
index 141759f..c382776 100644
--- a/catalog/camel-catalog-provider-karaf/src/main/java/org/apache/camel/catalog/karaf/KarafRuntimeProvider.java
+++ b/catalog/camel-catalog-provider-karaf/src/main/java/org/apache/camel/catalog/karaf/KarafRuntimeProvider.java
@@ -90,7 +90,7 @@ public class KarafRuntimeProvider implements RuntimeProvider {
     @Override
     public List<String> findComponentNames() {
         List<String> names = new ArrayList<>();
-        InputStream is = camelCatalog.getVersionManager().getResourceAsStream(COMPONENTS_CATALOG);
+        try (InputStream is = camelCatalog.getVersionManager().getResourceAsStream(COMPONENTS_CATALOG)) {
         if (is != null) {
             try {
                 CatalogHelper.loadLines(is, names);
@@ -98,13 +98,16 @@ public class KarafRuntimeProvider implements RuntimeProvider {
                 // ignore
             }
         }
+        } catch (IOException e1) {
+			// ignore
+		}
         return names;
     }
 
     @Override
     public List<String> findDataFormatNames() {
         List<String> names = new ArrayList<>();
-        InputStream is = camelCatalog.getVersionManager().getResourceAsStream(DATA_FORMATS_CATALOG);
+        try (InputStream is = camelCatalog.getVersionManager().getResourceAsStream(DATA_FORMATS_CATALOG)) {
         if (is != null) {
             try {
                 CatalogHelper.loadLines(is, names);
@@ -112,13 +115,16 @@ public class KarafRuntimeProvider implements RuntimeProvider {
                 // ignore
             }
         }
+        } catch (IOException e1) {
+			// ignore
+		}
         return names;
     }
 
     @Override
     public List<String> findLanguageNames() {
         List<String> names = new ArrayList<>();
-        InputStream is = camelCatalog.getVersionManager().getResourceAsStream(LANGUAGE_CATALOG);
+        try (InputStream is = camelCatalog.getVersionManager().getResourceAsStream(LANGUAGE_CATALOG)) {
         if (is != null) {
             try {
                 CatalogHelper.loadLines(is, names);
@@ -126,13 +132,16 @@ public class KarafRuntimeProvider implements RuntimeProvider {
                 // ignore
             }
         }
+        } catch (IOException e1) {
+			// ignore
+		}
         return names;
     }
 
     @Override
     public List<String> findOtherNames() {
         List<String> names = new ArrayList<>();
-        InputStream is = camelCatalog.getVersionManager().getResourceAsStream(OTHER_CATALOG);
+        try (InputStream is = camelCatalog.getVersionManager().getResourceAsStream(OTHER_CATALOG)) {
         if (is != null) {
             try {
                 CatalogHelper.loadLines(is, names);
@@ -140,6 +149,9 @@ public class KarafRuntimeProvider implements RuntimeProvider {
                 // ignore
             }
         }
+        } catch (IOException e1) {
+			// ignore
+		}
         return names;
     }