[GitHub] [skywalking-python] tom-pytel commented on pull request #116: fix: grpc timeout segment data loss

[GitBox <gi...@apache.org>]

tom-pytel commented on pull request #116:
URL: https://github.com/apache/skywalking-python/pull/116#issuecomment-768404151


   > From my understanding, the timeout should make the segments abandoned with keeping the agent memory as much as possible.
   > This is not specific for the agent, it is recommended, implemented, and kept in all agents. The users will never know how to determine which trace segments should be kept, and others are not in the runtime.
   > I am not checking the codes, but it should be in this way. @kezhenxu94
   
   Well there is already a mechanism to reject segments if the queue is full, in agent/__init__.py:archive() the queue is explicitly checked and segment is rejected if full. All I am trying to do is if queue is not full to not lose the segments that are there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org