You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/04 09:46:30 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #4993: ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Pearl1594 opened a new pull request #4993:
URL: https://github.com/apache/cloudstack/pull/4993


   ### Description
   
   From the Zones -> Physical Network (Guest) -> Traffic Types View, when we attempt to create a network, Cancel / Creation of network operation doesn't close the form. This PR fixes the issue.
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Attempted creating a network from the Zones View and observed that the form closes on completion of action
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4993: ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4993:
URL: https://github.com/apache/cloudstack/pull/4993#issuecomment-831819093


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4993 (SL-JID-126)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4993: ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4993:
URL: https://github.com/apache/cloudstack/pull/4993#issuecomment-831816958


   @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4993: ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4993:
URL: https://github.com/apache/cloudstack/pull/4993


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #4993: ui: Close Create network form from Zones -> Physical Network (Guest) -> Traffic Type view

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4993:
URL: https://github.com/apache/cloudstack/pull/4993#issuecomment-831816715


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org