You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:51:24 UTC
[GitHub] [zookeeper] bigmarvin opened a new pull request #1728: ZOOKEEPER-4331: add headers back manually
bigmarvin opened a new pull request #1728:
URL: https://github.com/apache/zookeeper/pull/1728
Following up https://github.com/apache/zookeeper/pull/1723, I'm applying the change on master instead of 3.5.x as advised.
As an alternative to https://github.com/apache/zookeeper/pull/1726, this change plants manifest entries required by osgi.
The advantage would be the least modification to the code base in all 3 approaches.
The disadvantage would be manual maintenance of these entries, which is too expensive and thus practically impossible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar closed pull request #1728: ZOOKEEPER-4331: add headers back manually
Posted by GitBox <gi...@apache.org>.
nkalmar closed pull request #1728:
URL: https://github.com/apache/zookeeper/pull/1728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] bigmarvin edited a comment on pull request #1728: ZOOKEEPER-4331: add headers back manually
Posted by GitBox <gi...@apache.org>.
bigmarvin edited a comment on pull request #1728:
URL: https://github.com/apache/zookeeper/pull/1728#issuecomment-878133432
May I retrigger the failed check somehow? I don't see it relate to the change in any way.
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1728/1/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] bigmarvin commented on pull request #1728: ZOOKEEPER-4331: add headers back manually
Posted by GitBox <gi...@apache.org>.
bigmarvin commented on pull request #1728:
URL: https://github.com/apache/zookeeper/pull/1728#issuecomment-878133432
May I somehow retrigger the failed check somehow? I don't see it relate to the change in any way.
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1728/1/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1728: ZOOKEEPER-4331: add headers back manually
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1728:
URL: https://github.com/apache/zookeeper/pull/1728#issuecomment-891707606
Also closing this one in favor of https://github.com/apache/zookeeper/pull/1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org