[GitHub] [airflow] jedcunningham commented on a diff in pull request #26341: Improve 'start-airflow' experience for users and ui developers

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #26341:
URL: https://github.com/apache/airflow/pull/26341#discussion_r971373620


##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -213,6 +213,18 @@ def shell(
 @option_mount_sources
 @option_integration
 @option_image_tag_for_running
+@click.option(
+    '--skip-asset-compilation',
+    help="Skips compilation of assets when starting airflow even if the content of www changed "
+    "(mutually exclusive with --dev-mode).",
+    is_flag=True,
+)
+@click.option(
+    '--dev-mode',
+    help="Starts webserver in dev mode (assets are always recompiled in this case when starting "

Review Comment:
   ```suggestion
       help="Starts webserver in dev mode (assets are always recompiled in this case when starting) "
   ```
   
   Oh no, you dropped one!



##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -236,15 +248,24 @@ def start_airflow(
     use_packages_from_dist: bool,
     package_format: str,
     force_build: bool,
+    skip_asset_compilation: bool,
+    dev_mode: bool,
     image_tag: str | None,
     db_reset: bool,
     answer: str | None,
     platform: str | None,
     extra_args: tuple,
 ):
-    """Enter breeze environment and starts all Airflow components in the tmux session."""
-    if use_airflow_version is None:
-        run_compile_www_assets(dev=False, verbose=verbose, dry_run=dry_run)
+    """
+    Enter breeze environment and starts all Airflow components in the tmux session.
+    Compile assets if contents of www directory changed."""

Review Comment:
   ```suggestion
       Compile assets if contents of www directory changed.
       """
   ```
   
   nit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org