You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2016/07/25 19:25:38 UTC
Review Request 50405: HIVE-14251: Union All of different types
resolves to incorrect data
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50405/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-14251: Union All of different types resolves to incorrect data
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 69a18cd3b4e383f5f7eb9b8cbffd133b13b5a595
ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 59ecd1ec6e617927395912a5fc9b78d840ea734b
ql/src/test/queries/clientpositive/alter_table_cascade.q acca4e8675290f1cc951a1eca96cd8ca70a18109
ql/src/test/queries/clientpositive/groupby_sort_1_23.q 67fdd234b424ce27d1f9c0b79f32850a1685bdd3
ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q 39b9420ac84f4a9f8762bd123865d6f38dc3e0a3
ql/src/test/queries/clientpositive/union32.q f47f0afae2dba196da285d73de879c6c6ab91da3
ql/src/test/queries/clientpositive/union33.q 017442e6b35ededdf5754895a182c7ac64ef9427
ql/src/test/queries/clientpositive/union36.q c38e7b1287fe0f28cc3176558b5f35070c8e00c5
ql/src/test/queries/clientpositive/unionDistinct_1.q fd7f075fc0f3110ff526b174555af71853318b00
ql/src/test/queries/clientpositive/union_date_trim.q 6842e564419a9d461a4ba6421083a6ebbf7f6342
ql/src/test/queries/clientpositive/union_null.q a17325c9f9951b3737f9d07af3309961347619d4
ql/src/test/queries/clientpositive/union_remove_12.q f6436f5e979b90403d8ec342d69c4e25382866c3
ql/src/test/queries/clientpositive/union_remove_13.q b02451b0458a6c79c28d8d4f0f0c894a9f0e11cb
ql/src/test/queries/clientpositive/union_remove_14.q bec622605e0f04afbc23e61b7025727f2040e6da
ql/src/test/queries/clientpositive/union_type_chk.q 3b7b47839cde4dcc097ba4176cba5b9144c47365
ql/src/test/queries/clientpositive/unionall_join_nullconstant.q 4f0ffa6ff562f83056974a5c67ffa1896e041449
ql/src/test/results/clientpositive/alter_table_cascade.q.out 1d8204ceab8b890f230007be0986a94e36ca748f
ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 81fe0d9a50e99acbeb8e5d36953ccb338eed00d1
ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 5cf0ea208f22a6ced5cca5f18cab70f7f8bb8d94
ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 408c1b9b6f479bf9fa0e62dbe2f2ec52cd7e0ca5
ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 63258894eccc1fcbe7fb13f636fded9cd7813be6
ql/src/test/results/clientpositive/spark/union32.q.out 1ec7e646b7893ca11daf2c661f4606d41f96e117
ql/src/test/results/clientpositive/spark/union33.q.out a61a8df38f61aa3cf0e96f3c297fb8352f013547
ql/src/test/results/clientpositive/spark/union_date_trim.q.out 324e8b7ddb1ae81d548965612be14e9754663b90
ql/src/test/results/clientpositive/spark/union_null.q.out 32cdf65ce845fb133efee29322effc645baa53d0
ql/src/test/results/clientpositive/spark/union_remove_12.q.out 94b42119431b64c889674f156ab6d41c74b19954
ql/src/test/results/clientpositive/spark/union_remove_13.q.out 42aea66a185d6e73e68fab4c72cd77bd8ad1049c
ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf6d36f1d3a9c289dd4f8ef594bfd0e5ddd110c7
ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out ee330864ef0a455a834a1ebe92dd1263908dcf3e
ql/src/test/results/clientpositive/tez/union_type_chk.q.out 12f060bb23819919aaf5ca73aa18f37db4f254e2
ql/src/test/results/clientpositive/union32.q.out a3fefa86d58dd51ecffdda12da59feb4193c5d61
ql/src/test/results/clientpositive/union33.q.out a91e74cd1e7b4c7d93e5b71f28c1555d94ed5747
ql/src/test/results/clientpositive/union36.q.out 12f060bb23819919aaf5ca73aa18f37db4f254e2
ql/src/test/results/clientpositive/unionDistinct_1.q.out 0330133917511c355fca3adeb3e5d07eaeb3c0fc
ql/src/test/results/clientpositive/union_date_trim.q.out 324e8b7ddb1ae81d548965612be14e9754663b90
ql/src/test/results/clientpositive/union_null.q.out 32cdf65ce845fb133efee29322effc645baa53d0
ql/src/test/results/clientpositive/union_remove_12.q.out 5f73c9aeca123a032e1b4cb4920f7ead0991572e
ql/src/test/results/clientpositive/union_remove_13.q.out c7063cd56c74695ce7ac740eb2adeb27d46bbb81
ql/src/test/results/clientpositive/union_remove_14.q.out 52dc7c5662e13f4165a2a6e3a3f1d85b60aec620
ql/src/test/results/clientpositive/union_type_chk.q.out 12f060bb23819919aaf5ca73aa18f37db4f254e2
ql/src/test/results/clientpositive/unionall_join_nullconstant.q.out fca26b413939ba6244ccabb944771275e1941723
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 8f7b7994003d909e83f0dbb4b80b868fb2a27b99
Diff: https://reviews.apache.org/r/50405/diff/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 50405: HIVE-14251: Union All of different types
resolves to incorrect data
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50405/#review144977
-----------------------------------------------------------
Ship it!
Ship It!
- Mohit Sabharwal
On July 26, 2016, 3:13 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50405/
> -----------------------------------------------------------
>
> (Updated July 26, 2016, 3:13 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14251: Union All of different types resolves to incorrect data
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 69a18cd
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 59ecd1e
> ql/src/test/queries/clientpositive/alter_partition_change_col.q 360f4d2
> ql/src/test/queries/clientpositive/alter_table_cascade.q acca4e8
> ql/src/test/queries/clientpositive/groupby_sort_1_23.q 67fdd23
> ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q 39b9420
> ql/src/test/queries/clientpositive/union32.q f47f0af
> ql/src/test/queries/clientpositive/union33.q 017442e
> ql/src/test/queries/clientpositive/union36.q c38e7b1
> ql/src/test/queries/clientpositive/unionDistinct_1.q fd7f075
> ql/src/test/queries/clientpositive/union_date_trim.q 6842e56
> ql/src/test/queries/clientpositive/union_null.q a17325c
> ql/src/test/queries/clientpositive/union_remove_12.q f6436f5
> ql/src/test/queries/clientpositive/union_remove_13.q b02451b
> ql/src/test/queries/clientpositive/union_remove_14.q bec6226
> ql/src/test/queries/clientpositive/union_type_chk.q 3b7b478
> ql/src/test/queries/clientpositive/unionall_join_nullconstant.q 4f0ffa6
> ql/src/test/results/clientpositive/alter_partition_change_col.q.out 23febee
> ql/src/test/results/clientpositive/alter_table_cascade.q.out 1d8204c
> ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 81fe0d9
> ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 5cf0ea2
> ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 408c1b9
> ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 6325889
> ql/src/test/results/clientpositive/spark/union32.q.out 1ec7e64
> ql/src/test/results/clientpositive/spark/union33.q.out a61a8df
> ql/src/test/results/clientpositive/spark/union_date_trim.q.out 324e8b7
> ql/src/test/results/clientpositive/spark/union_null.q.out 32cdf65
> ql/src/test/results/clientpositive/spark/union_remove_12.q.out 94b4211
> ql/src/test/results/clientpositive/spark/union_remove_13.q.out 42aea66
> ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf6d36f
> ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out ee33086
> ql/src/test/results/clientpositive/tez/union_type_chk.q.out 12f060b
> ql/src/test/results/clientpositive/union32.q.out a3fefa8
> ql/src/test/results/clientpositive/union33.q.out a91e74c
> ql/src/test/results/clientpositive/union36.q.out 12f060b
> ql/src/test/results/clientpositive/unionDistinct_1.q.out 0330133
> ql/src/test/results/clientpositive/union_date_trim.q.out 324e8b7
> ql/src/test/results/clientpositive/union_null.q.out 32cdf65
> ql/src/test/results/clientpositive/union_remove_12.q.out 5f73c9a
> ql/src/test/results/clientpositive/union_remove_13.q.out c7063cd
> ql/src/test/results/clientpositive/union_remove_14.q.out 52dc7c5
> ql/src/test/results/clientpositive/union_type_chk.q.out 12f060b
> ql/src/test/results/clientpositive/unionall_join_nullconstant.q.out fca26b4
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 8f7b799
>
> Diff: https://reviews.apache.org/r/50405/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 50405: HIVE-14251: Union All of different types
resolves to incorrect data
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50405/
-----------------------------------------------------------
(Updated July 26, 2016, 3:13 p.m.)
Review request for hive.
Changes
-------
unit test change.
Repository: hive-git
Description
-------
HIVE-14251: Union All of different types resolves to incorrect data
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 69a18cd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 59ecd1e
ql/src/test/queries/clientpositive/alter_partition_change_col.q 360f4d2
ql/src/test/queries/clientpositive/alter_table_cascade.q acca4e8
ql/src/test/queries/clientpositive/groupby_sort_1_23.q 67fdd23
ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q 39b9420
ql/src/test/queries/clientpositive/union32.q f47f0af
ql/src/test/queries/clientpositive/union33.q 017442e
ql/src/test/queries/clientpositive/union36.q c38e7b1
ql/src/test/queries/clientpositive/unionDistinct_1.q fd7f075
ql/src/test/queries/clientpositive/union_date_trim.q 6842e56
ql/src/test/queries/clientpositive/union_null.q a17325c
ql/src/test/queries/clientpositive/union_remove_12.q f6436f5
ql/src/test/queries/clientpositive/union_remove_13.q b02451b
ql/src/test/queries/clientpositive/union_remove_14.q bec6226
ql/src/test/queries/clientpositive/union_type_chk.q 3b7b478
ql/src/test/queries/clientpositive/unionall_join_nullconstant.q 4f0ffa6
ql/src/test/results/clientpositive/alter_partition_change_col.q.out 23febee
ql/src/test/results/clientpositive/alter_table_cascade.q.out 1d8204c
ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 81fe0d9
ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 5cf0ea2
ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 408c1b9
ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 6325889
ql/src/test/results/clientpositive/spark/union32.q.out 1ec7e64
ql/src/test/results/clientpositive/spark/union33.q.out a61a8df
ql/src/test/results/clientpositive/spark/union_date_trim.q.out 324e8b7
ql/src/test/results/clientpositive/spark/union_null.q.out 32cdf65
ql/src/test/results/clientpositive/spark/union_remove_12.q.out 94b4211
ql/src/test/results/clientpositive/spark/union_remove_13.q.out 42aea66
ql/src/test/results/clientpositive/spark/union_remove_14.q.out cf6d36f
ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out ee33086
ql/src/test/results/clientpositive/tez/union_type_chk.q.out 12f060b
ql/src/test/results/clientpositive/union32.q.out a3fefa8
ql/src/test/results/clientpositive/union33.q.out a91e74c
ql/src/test/results/clientpositive/union36.q.out 12f060b
ql/src/test/results/clientpositive/unionDistinct_1.q.out 0330133
ql/src/test/results/clientpositive/union_date_trim.q.out 324e8b7
ql/src/test/results/clientpositive/union_null.q.out 32cdf65
ql/src/test/results/clientpositive/union_remove_12.q.out 5f73c9a
ql/src/test/results/clientpositive/union_remove_13.q.out c7063cd
ql/src/test/results/clientpositive/union_remove_14.q.out 52dc7c5
ql/src/test/results/clientpositive/union_type_chk.q.out 12f060b
ql/src/test/results/clientpositive/unionall_join_nullconstant.q.out fca26b4
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 8f7b799
Diff: https://reviews.apache.org/r/50405/diff/
Testing
-------
Thanks,
Aihua Xu