Re: [PR] NoSQL: revalidate grant entities before grant or revoke [polaris]

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #4234:
URL: https://github.com/apache/polaris/pull/4234#discussion_r3104234279


##########
persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStore.java:
##########
@@ -284,7 +284,8 @@ CreateCatalogResult createCatalog(
                     catalogAdminRole, effRole, PolarisPrivilege.CATALOG_ROLE_USAGE));
           }
 
-          persistGrantsOrRevokes(true, grants.toArray(SecurableGranteePrivilegeTuple[]::new));
+          persistGrantsOrRevokes(

Review Comment:
   side note: in the spirit of recent Authorizer work, it feel that internal grants should not be forcefully combined with the catalog creation operation, but instead be done separately... For example, if the authorizer is OPA, these grants are irrelevant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org