You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jamesnetherton (via GitHub)" <gi...@apache.org> on 2023/07/05 12:59:26 UTC

[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5060: Improve native support of camel-quarkus-debug

jamesnetherton commented on code in PR #5060:
URL: https://github.com/apache/camel-quarkus/pull/5060#discussion_r1253070616


##########
extensions/debug/deployment/src/main/java/org/apache/camel/quarkus/component/debug/deployment/DebugProcessor.java:
##########
@@ -16,18 +16,29 @@
  */
 package org.apache.camel.quarkus.component.debug.deployment;
 
+import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.function.BooleanSupplier;
 
+import io.quarkus.deployment.annotations.BuildProducer;
 import io.quarkus.deployment.annotations.BuildStep;
 import io.quarkus.deployment.builditem.AllowJNDIBuildItem;
 import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.SystemPropertyBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
 import io.quarkus.runtime.LaunchMode;
 import org.apache.camel.quarkus.component.debug.DebugConfig;
 import org.apache.camel.quarkus.core.deployment.spi.CamelServiceDestination;
 import org.apache.camel.quarkus.core.deployment.spi.CamelServicePatternBuildItem;
 import org.eclipse.microprofile.config.ConfigProvider;
 
 class DebugProcessor {
+
+    private static final String[] SERIALIZATION_CLASSES = {

Review Comment:
   Since the management extension already produces `CamelSerializationBuildItem`. We could maybe add these into the common set of classes we configure for serialization, WDYT?
   
   https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSerializationProcessor.java#L40
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org