[jira] [Comment Edited] (FLINK-27615) Document the how to define namespaceSelector for k8s operator's webhook

["Biao Geng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537012#comment-17537012 ] 

Biao Geng edited comment on FLINK-27615 at 5/14/22 10:29 AM:
-------------------------------------------------------------

[~aitozi] I think your proposal makes sense.

I checked the release notes of k8s and just noticed that the 1.21.1 was just released 1 year ago. It looks like k8s iterates much more quickly than flink. IIUC, users, especially those use k8s in production, will not update k8s to new versions frequently. 
I was doing my tests on k8s 1.20.4. Currently, besides the nameSelector feature, I have not met other issues. To support more k8s versions, I agree with you on makeing this feature non-default with better documents 


was (Author: bgeng777):
[~aitozi] I think your proposal makes a lot of sense.

I checked the release notes of k8s and just noticed that the 1.21.1 was just released 1 year ago. K8s iterates much more quickly than flink. IIUC, users, especially those use k8s in production, will not update k8s to new versions frequently. 
I was doing my tests on k8s 1.20.4. Currently, besides the nameSelector feature, I have not met other issues. To support more k8s versions, I agree with you on makeing this feature non-default with better documents 

> Document the how to define namespaceSelector for k8s operator's webhook
> -----------------------------------------------------------------------
>
>                 Key: FLINK-27615
>                 URL: https://issues.apache.org/jira/browse/FLINK-27615
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>            Reporter: Biao Geng
>            Priority: Major
>
> In our webhook, to support {{{}watchNamespaces{}}}, we rely on the {{kubernetes.io/metadata.name}} to filter the validation requests. However, this label will be automatically added to a namespace only since k8s 1.21.1 due to k8s' [release notes|https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.21.md#v1211] .  If users run the flink k8s operator on older k8s versions, they have to add such label by themselevs to support the feature of namespaceSelector in our webhook.
> As a result, if we want to support the feature defaultly, we may need to emphasize that users should use k8s >= v1.21.1 to run the flink k8s operator.
>  
> Due to aitozi's advice, it may be better to add document of how to support the nameSelector based validation instead of limiting the k8s version to be >= 1.21.1 to support more users.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)