You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/03 09:54:48 UTC

[GitHub] [orc] pgaref commented on pull request #586: ORC-703 : Fix RLE encoding bug on large negative integer.

pgaref commented on pull request #586:
URL: https://github.com/apache/orc/pull/586#issuecomment-753592692


   Btw, seems like the ORC-616 FIX is actually missing PATCH encoding opportunities with the LIMIT check (and using the most wasteful DIRECT instead) https://github.com/apache/orc/pull/601/files#diff-c76000edca5c4182015a83c604c01b032d4a97e31c0050c0e3ce0ccd195f284fR536
   
   In reality, the only thing we need to check is if the number to be encoded is negative (already including the sign bit) and avoid accounting for the extra sign bit. https://github.com/apache/orc/pull/601/files#diff-c76000edca5c4182015a83c604c01b032d4a97e31c0050c0e3ce0ccd195f284fR291
   
   Created a proof of concept for the java side of things as part of #601  -- please let me know what you think


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org