[GitHub] [kafka] gharris1727 commented on pull request #13262: KAFKA-14727: Enable periodic offset commits for EOS source tasks

["gharris1727 (via GitHub)" <gi...@apache.org>]

gharris1727 commented on PR #13262:
URL: https://github.com/apache/kafka/pull/13262#issuecomment-1433589831

   > Could we also add a case to ExactlyOnceWorkerSourceTaskTest that ensures that SourceTask::commit is invoked even if the task doesn't produce any records?
   
   This is covered by the existing `testPollReturnsNoRecords` where the two arguments to verifyTransactions are different.
   
   Also the tests uncovered a difference in behavior for `testSlowTaskStart`: If the task is started and then stopped before the start() method completes, the final task shutdown now calls commit().


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org