You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/23 06:27:50 UTC
[PR] THRIFT-6336: Render a uuid constant as its value in the JavaScript generator [thrift]
slachiewicz opened a new pull request, #3936:
URL: https://github.com/apache/thrift/pull/3936
A `uuid` constant in `--gen js` output was the address of the `t_const_value`, different on every run (`test/ConstantsDemo.thrift` has one). The `TYPE_UUID` case now writes the escaped string, as the string case above it does.
Verified: `--gen js` over every `.thrift` in the repository, master against this branch → only uuid values change, in 3 files.
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6336](https://issues.apache.org/jira/browse/THRIFT-6336)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit?
- [x] Did you do your best to avoid breaking changes? No: generated code was unusable before.
- [x] Code change, so the commit carries no CI-skip marker.
- [x] Tests: `compiler/cpp/tests/js/t_js_generator_uuid_const_tests.cc`, which fails without the fix; js generator tests are switched on in `compiler/cpp/tests/CMakeLists.txt`.
- [x] AI-assisted: the commit carries a `Co-Authored-By:` trailer. No new dependency or third-party code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6336: Render a uuid constant as its value in the JavaScript generator [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3936:
URL: https://github.com/apache/thrift/pull/3936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6336: Render a uuid constant as its value in the JavaScript generator [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3936:
URL: https://github.com/apache/thrift/pull/3936#issuecomment-5846750941
### Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org