You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/28 10:36:21 UTC

[GitHub] [flink] AHeise commented on a change in pull request #10345: [FLINK-12484][runtime] synchronize all mailbox actions

AHeise commented on a change in pull request #10345: [FLINK-12484][runtime] synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r351698119
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -384,57 +386,59 @@ protected Counter setupNumRecordsInCounter(StreamOperator streamOperator) {
 		}
 	}
 
-	@Override
-	public final void invoke() throws Exception {
+	private void beforeInvoke() throws Exception {
 
 Review comment:
   👍  for splitting huge ugly methods, but I'd like to have better names for the new methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services