You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/01/08 02:22:59 UTC

[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #705: [IOTDB-396] New query clause: disable align

JackieTien97 commented on a change in pull request #705: [IOTDB-396] New query clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/705#discussion_r364034385
 
 

 ##########
 File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBQueryResultSet.java
 ##########
 @@ -1226,7 +1380,7 @@ public boolean wasNull() throws SQLException {
   }
 
   private void checkRecord() throws SQLException {
-    if (Objects.isNull(tsQueryDataSet)) {
+    if (Objects.isNull(tsQueryDataSet) && Objects.isNull(tsQueryNonAlignDataSet)) {
 
 Review comment:
   I agree, we should extract an abstract super class to reserve some common functions and make the two different dataset extend to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services