You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/19 23:49:42 UTC
Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Till Toenshoff.
Repository: mesos-git
Description
-------
See summary. cgroups::enabled() is not available on OSX.
Diffs
-----
src/tests/environment.cpp 3f4eaad
src/tests/slave_recovery_tests.cpp 11a1430
Diff: https://reviews.apache.org/r/21664/diff/
Testing
-------
make check on OSX
make check and sudo make check on Linux
Thanks,
Jie Yu
Re: Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
Posted by Till Toenshoff <to...@me.com>.
> On May 19, 2014, 9:55 p.m., Till Toenshoff wrote:
> > src/tests/environment.cpp, line 137
> > <https://reviews.apache.org/r/21664/diff/2/?file=584703#file584703line137>
> >
> > Couldn't you drop those outer brackets?
Sry, did not mean to raise this as an issue as I am unsure about our style for these cases.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/#review43425
-----------------------------------------------------------
On May 19, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21664/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. cgroups::enabled() is not available on OSX.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 3f4eaad
> src/tests/slave_recovery_tests.cpp 11a1430
>
> Diff: https://reviews.apache.org/r/21664/diff/
>
>
> Testing
> -------
>
> make check on OSX
> make check and sudo make check on Linux
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
Posted by Jie Yu <yu...@gmail.com>.
> On May 19, 2014, 9:55 p.m., Till Toenshoff wrote:
> > src/tests/environment.cpp, line 137
> > <https://reviews.apache.org/r/21664/diff/2/?file=584703#file584703line137>
> >
> > Couldn't you drop those outer brackets?
>
> Till Toenshoff wrote:
> Sry, did not mean to raise this as an issue as I am unsure about our style for these cases.
Done!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/#review43425
-----------------------------------------------------------
On May 19, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21664/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. cgroups::enabled() is not available on OSX.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 3f4eaad
> src/tests/slave_recovery_tests.cpp 11a1430
>
> Diff: https://reviews.apache.org/r/21664/diff/
>
>
> Testing
> -------
>
> make check on OSX
> make check and sudo make check on Linux
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/#review43425
-----------------------------------------------------------
Ship it!
Ship it!
src/tests/environment.cpp
<https://reviews.apache.org/r/21664/#comment77560>
Couldn't you drop those outer brackets?
- Till Toenshoff
On May 19, 2014, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21664/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 9:49 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. cgroups::enabled() is not available on OSX.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 3f4eaad
> src/tests/slave_recovery_tests.cpp 11a1430
>
> Diff: https://reviews.apache.org/r/21664/diff/
>
>
> Testing
> -------
>
> make check on OSX
> make check and sudo make check on Linux
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/
-----------------------------------------------------------
(Updated May 19, 2014, 10:10 p.m.)
Review request for mesos, Dominic Hamon and Till Toenshoff.
Changes
-------
Review comments.
Repository: mesos-git
Description
-------
See summary. cgroups::enabled() is not available on OSX.
Diffs (updated)
-----
src/tests/environment.cpp 3f4eaad
src/tests/slave_recovery_tests.cpp 11a1430
Diff: https://reviews.apache.org/r/21664/diff/
Testing
-------
make check on OSX
make check and sudo make check on Linux
Thanks,
Jie Yu
Re: Review Request 21664: Fixed the broken build on OSX caused by
cgroups::enabled().
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21664/#review43424
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 19, 2014, 2:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21664/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 2:49 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Till Toenshoff.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. cgroups::enabled() is not available on OSX.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 3f4eaad
> src/tests/slave_recovery_tests.cpp 11a1430
>
> Diff: https://reviews.apache.org/r/21664/diff/
>
>
> Testing
> -------
>
> make check on OSX
> make check and sudo make check on Linux
>
>
> Thanks,
>
> Jie Yu
>
>