You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2006/06/05 18:20:43 UTC

[jira] Created: (HARMONY-561) Modularise native include directories

Modularise native include directories
-------------------------------------

         Key: HARMONY-561
         URL: http://issues.apache.org/jira/browse/HARMONY-561
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Oliver Deakin


There has been discussion on harmony-dev about moving the natives into the modules directory [1].
One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).

I will attach a proposed patch to make these changes.


[1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
[2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-561) Modularise native include directories

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-561?page=all ]
     
Tim Ellison resolved HARMONY-561:
---------------------------------

    Resolution: Fixed

Thanks Oliver.

Patch applied at repo revision r412357.

Please check that the patch was applied as you expected.


> Modularise native include directories
> -------------------------------------
>
>          Key: HARMONY-561
>          URL: http://issues.apache.org/jira/browse/HARMONY-561
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.includes.diff, modularise.includes.sh
>
> There has been discussion on harmony-dev about moving the natives into the modules directory [1].
> One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).
> I will attach a proposed patch to make these changes.
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
> [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-561) Modularise native include directories

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-561?page=comments#action_12415133 ] 

Oliver Deakin commented on HARMONY-561:
---------------------------------------

Looks good, thanks for applying the patches Tim

> Modularise native include directories
> -------------------------------------
>
>          Key: HARMONY-561
>          URL: http://issues.apache.org/jira/browse/HARMONY-561
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.includes.diff, modularise.includes.sh
>
> There has been discussion on harmony-dev about moving the natives into the modules directory [1].
> One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).
> I will attach a proposed patch to make these changes.
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
> [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-561) Modularise native include directories

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-561?page=all ]
     
Tim Ellison closed HARMONY-561:
-------------------------------


Verified by Oliver.


> Modularise native include directories
> -------------------------------------
>
>          Key: HARMONY-561
>          URL: http://issues.apache.org/jira/browse/HARMONY-561
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.includes.diff, modularise.includes.sh
>
> There has been discussion on harmony-dev about moving the natives into the modules directory [1].
> One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).
> I will attach a proposed patch to make these changes.
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
> [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-561) Modularise native include directories

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-561?page=all ]

Oliver Deakin updated HARMONY-561:
----------------------------------

    Attachment: modularise.includes.sh
                modularise.includes.diff

To apply these patches, please first run modularise.includes.sh in the root directory of your classlib/trunk checkout. Then apply the modularise.includes.diff patch.

modularise.includes.sh creates modules/<modulename>/src/main/native/include directories in luni and archive, and then moves header files from native-src/<platform>/include into their appropriate location.
Some files that are not actually being used by more than one native component are moved into their relevant component instead of being shared.

modularise.includes.diff patches up the build system to understand the new include locations, and to share the necessary includes at build time.

> Modularise native include directories
> -------------------------------------
>
>          Key: HARMONY-561
>          URL: http://issues.apache.org/jira/browse/HARMONY-561
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>  Attachments: modularise.includes.diff, modularise.includes.sh
>
> There has been discussion on harmony-dev about moving the natives into the modules directory [1].
> One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).
> I will attach a proposed patch to make these changes.
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
> [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-561) Modularise native include directories

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-561?page=all ]

Tim Ellison reassigned HARMONY-561:
-----------------------------------

    Assign To: Tim Ellison

> Modularise native include directories
> -------------------------------------
>
>          Key: HARMONY-561
>          URL: http://issues.apache.org/jira/browse/HARMONY-561
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Oliver Deakin
>     Assignee: Tim Ellison
>  Attachments: modularise.includes.diff, modularise.includes.sh
>
> There has been discussion on harmony-dev about moving the natives into the modules directory [1].
> One of the first steps towards achieving this goal is to move the contents of the native-src/<platform>/include directories into their relevant modules, and alter the build.xml's of those modules to move them into a shared place at build time (i.e. <hdk>/include [2]).
> I will attach a proposed patch to make these changes.
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200605.mbox/%3c4463654A.3080105@googlemail.com%3e
> [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/hdk.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira